neutron

QoS policy object should not raise an exception for version degradation < 1.3

Bug #1677303 reported by David Shaughnessy
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Invalid
Undecided
Rodolfo Alonso

Bug Description

"The oslo.versionedobjects library can be used to define a data model within a project independent of external APIs or database schema for the purposes of providing upgrade compatibility across distributed services."

QoS policy object is raising an exception when the object version is downgraded to < 1.3 [1]

Instead of this, the function "obj_make_compatible" should gently adapt the new versioned object.

[1] https://github.com/openstack/neutron/blob/master/neutron/objects/qos/policy.py#L240

See original description
Brian Haley (brian-haley)
tags: added: needs-attention
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/454220

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote : Re: QoS Oslo Versioned Objects used for micro-versioning rather than to conform API to the highest common object version.

I am not sure which problem you try to solve here. What's the use case that fails for you?

Changed in neutron:
status: In Progress → Incomplete
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Description changed, scope reduced.

summary: - QoS Oslo Versioned Objects used for micro-versioning rather than to
- conform API to the highest common object version.
+ QoS policy object should not raise an exception for version degradation
+ < 1.3
Rodolfo Alonso (rodolfo-alonso-hernandez)
description: updated
OpenStack Infra (hudson-openstack)
Changed in neutron:
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.openstack.org/454220
Reason: This patch is superseded by https://review.openstack.org/#/c/456637/: "qos: removed object compatibility code for pre Ocata"

Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.