eventlet 0.20.x breaks functional tests due to missing select.poll()

[Ihar Hrachyshka]

eventlet was bumped from 0.19.x to 0.20.1 in gate, and it broke functional job:

http://logs.openstack.org/78/385178/18/check/gate-neutron-dsvm-functional-ubuntu-xenial/184b97c/testr_results.html.gz

Traceback (most recent call last):
  File "neutron/tests/base.py", line 116, in func
    return f(self, *args, **kwargs)
  File "neutron/tests/functional/agent/l3/test_legacy_router.py", line 155, in test_conntrack_disassociate_fip_legacy_router
    self._test_conntrack_disassociate_fip(ha=False)
  File "neutron/tests/functional/agent/l3/framework.py", line 159, in _test_conntrack_disassociate_fip
    self.assertTrue(netcat.test_connectivity())
  File "neutron/tests/common/net_helpers.py", line 505, in test_connectivity
    message = self.server_process.read_stdout(READ_TIMEOUT).strip()
  File "neutron/tests/common/net_helpers.py", line 287, in read_stdout
    return self._read_stream(self.stdout, timeout)
  File "neutron/tests/common/net_helpers.py", line 292, in _read_stream
    poller = select.poll()
AttributeError: 'module' object has no attribute 'poll'

That's because as per release notes for 0.20.0, select.poll was removed:

http://eventlet.net/doc/changelog.html#id2

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/447817

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/447896

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/447817
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f48dbeda5c4f8f34fb0f56227254ea3b8f830005
Submitter: Jenkins
Branch: master

commit f48dbeda5c4f8f34fb0f56227254ea3b8f830005
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Mar 21 05:23:53 2017 +0000

    Switch RootHelperProcess from select.poll to select.select

    The new eventlet 0.20.x that the gate was recently bumped to [1] removed
    select.poll [2]. Instead, we should use select.select that is both
    supported by eventlet as well as available on all platforms.

    [1] I534b8d7d6c2fa00c1fa7d84b3438e6e2b2fcad9e
    [2] http://eventlet.net/doc/changelog.html#id2

    Change-Id: Ie649abf495e00e7e05de47520ed89bbcd28360db
    Closes-Bug: #1674557

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/448094

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/448095

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/448096

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/448096
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=38bca3d74fbb61b81e376c1747cc41c4acfe206a
Submitter: Jenkins
Branch: stable/mitaka

commit 38bca3d74fbb61b81e376c1747cc41c4acfe206a
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Mar 21 05:23:53 2017 +0000

    Switch RootHelperProcess from select.poll to select.select

    The new eventlet 0.20.x that the gate was recently bumped to [1] removed
    select.poll [2]. Instead, we should use select.select that is both
    supported by eventlet as well as available on all platforms.

    [1] I534b8d7d6c2fa00c1fa7d84b3438e6e2b2fcad9e
    [2] http://eventlet.net/doc/changelog.html#id2

    Conflicts:
     neutron/tests/common/net_helpers.py

    Change-Id: Ie649abf495e00e7e05de47520ed89bbcd28360db
    Closes-Bug: #1674557
    (cherry picked from commit f48dbeda5c4f8f34fb0f56227254ea3b8f830005)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/448094
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d516a4aad7196a1b9d02611f02804b4bb595ad50
Submitter: Jenkins
Branch: stable/ocata

commit d516a4aad7196a1b9d02611f02804b4bb595ad50
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Mar 21 05:23:53 2017 +0000

    Switch RootHelperProcess from select.poll to select.select

    The new eventlet 0.20.x that the gate was recently bumped to [1] removed
    select.poll [2]. Instead, we should use select.select that is both
    supported by eventlet as well as available on all platforms.

    [1] I534b8d7d6c2fa00c1fa7d84b3438e6e2b2fcad9e
    [2] http://eventlet.net/doc/changelog.html#id2

    Change-Id: Ie649abf495e00e7e05de47520ed89bbcd28360db
    Closes-Bug: #1674557
    (cherry picked from commit f48dbeda5c4f8f34fb0f56227254ea3b8f830005)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/448095
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c90f3a090cfddeeca975eb93be5e7122e3ba71ef
Submitter: Jenkins
Branch: stable/newton

commit c90f3a090cfddeeca975eb93be5e7122e3ba71ef
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Mar 21 05:23:53 2017 +0000

    Switch RootHelperProcess from select.poll to select.select

    The new eventlet 0.20.x that the gate was recently bumped to [1] removed
    select.poll [2]. Instead, we should use select.select that is both
    supported by eventlet as well as available on all platforms.

    [1] I534b8d7d6c2fa00c1fa7d84b3438e6e2b2fcad9e
    [2] http://eventlet.net/doc/changelog.html#id2

    Change-Id: Ie649abf495e00e7e05de47520ed89bbcd28360db
    Closes-Bug: #1674557
    (cherry picked from commit f48dbeda5c4f8f34fb0f56227254ea3b8f830005)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/447896
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a7898c54954396f8fdfe86a6445f5e5648407d5e
Submitter: Jenkins
Branch: master

commit a7898c54954396f8fdfe86a6445f5e5648407d5e
Author: Akihiro Motoki <email address hidden>
Date: Tue Mar 21 06:48:13 2017 +0000

    Simplify RootHelperProcess._read_stream()

    select() itself has timeout mechanism, so we do not need to use
    wait_until_true wrapper.

    Related-Bug: #1674557
    Change-Id: I35bc4716f0d1e0d92e7b7a3f6dcb6978e9d725f9

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ocata
Review: https://review.openstack.org/460927

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/460928

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/460927
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d76cbab90941e7ed8f6668114b6c28b7ed481d64
Submitter: Jenkins
Branch: stable/ocata

commit d76cbab90941e7ed8f6668114b6c28b7ed481d64
Author: Akihiro Motoki <email address hidden>
Date: Tue Mar 21 06:48:13 2017 +0000

    Simplify RootHelperProcess._read_stream()

    select() itself has timeout mechanism, so we do not need to use
    wait_until_true wrapper.

    Related-Bug: #1674557
    Change-Id: I35bc4716f0d1e0d92e7b7a3f6dcb6978e9d725f9
    (cherry picked from commit a7898c54954396f8fdfe86a6445f5e5648407d5e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/460928
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=128ebb02faf8027b8a6ac429204233a7293c2fcf
Submitter: Jenkins
Branch: stable/newton

commit 128ebb02faf8027b8a6ac429204233a7293c2fcf
Author: Akihiro Motoki <email address hidden>
Date: Tue Mar 21 06:48:13 2017 +0000

    Simplify RootHelperProcess._read_stream()

    select() itself has timeout mechanism, so we do not need to use
    wait_until_true wrapper.

    Related-Bug: #1674557
    Change-Id: I35bc4716f0d1e0d92e7b7a3f6dcb6978e9d725f9
    (cherry picked from commit a7898c54954396f8fdfe86a6445f5e5648407d5e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.2 release.