pecan missing custom tenant_id policy project_id matching

[Kevin Benton]

The pecan code is missing these two chunks of code to support filtering project_id based on tenant_id policies:

https://github.com/openstack/neutron/blob/cd947ac4d05a5301fb3bf704b0dd1ca39fd7e541/neutron/api/v2/base.py#L173-L179
https://github.com/openstack/neutron/blob/cd947ac4d05a5301fb3bf704b0dd1ca39fd7e541/neutron/api/v2/base.py#L193-L197

They need to be added in here:

https://github.com/openstack/neutron/blob/cd947ac4d05a5301fb3bf704b0dd1ca39fd7e541/neutron/pecan_wsgi/hooks/policy_enforcement.py#L225

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/447781

[Kevin Benton (kevinbenton)]

Upgrading to high since this is actually the cause of 1673124

[Anindita Das (anindita-das)]

Kevin, I am not able to reproduce the tempest test failure. I was able to create a network successfully using the following curl request:

curl -i -X POST http://localhost:9696/v2.0/networks -H "X-Auth-Token: <token>" -H "Content-Type: application/json" -d '{"network": {"project_id": "9b952d000055450b9b27c09e7497effcf", "name": "admin-created-with-project_id"}}'

I didn't get the failure listed in bug #1673124. Do you have any suggestions how I can trigger the failure?

[Ihar Hrachyshka (ihar-hrachyshka)]

Probably related: http://logs.openstack.org/06/440806/5/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/7c99ec7/console.html#_2017-04-16_05_10_24_879416

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/447781
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0193777e60216844019963f785cd28ca205c42a4
Submitter: Jenkins
Branch: master

commit 0193777e60216844019963f785cd28ca205c42a4
Author: Anindita Das <email address hidden>
Date: Tue Mar 21 03:37:25 2017 +0000

    [Pecan] Fix custom tenant_id project_id matching

    This patch fixes the missing custom tenant_id and project_id
    matching on policy_enforcement.py

    Change-Id: I278759f6b65cce7caa4f66fa694488b75f0459b6
    Closes-Bug: #1674517

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/474286

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/474287

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/474286
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0c0c60fecb644a8cb9d40435f52a06ff6a9d0af0
Submitter: Jenkins
Branch: stable/ocata

commit 0c0c60fecb644a8cb9d40435f52a06ff6a9d0af0
Author: Anindita Das <email address hidden>
Date: Tue Mar 21 03:37:25 2017 +0000

    [Pecan] Fix custom tenant_id project_id matching

    This patch fixes the missing custom tenant_id and project_id
    matching on policy_enforcement.py

    Change-Id: I278759f6b65cce7caa4f66fa694488b75f0459b6
    Closes-Bug: #1674517
    (cherry picked from commit 0193777e60216844019963f785cd28ca205c42a4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/474287
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7f207a7e1e93e911d83010fe8ed5c19ee640149c
Submitter: Jenkins
Branch: stable/newton

commit 7f207a7e1e93e911d83010fe8ed5c19ee640149c
Author: Anindita Das <email address hidden>
Date: Tue Mar 21 03:37:25 2017 +0000

    [Pecan] Fix custom tenant_id project_id matching

    This patch fixes the missing custom tenant_id and project_id
    matching on policy_enforcement.py

    Conflicts:
     neutron/tests/functional/pecan_wsgi/test_controllers.py

    Newton changes: neutron-lib did not have directory module, falling back
    to neutron.manager.

    Change-Id: I278759f6b65cce7caa4f66fa694488b75f0459b6
    Closes-Bug: #1674517
    (cherry picked from commit 0193777e60216844019963f785cd28ca205c42a4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.4.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.3 release.