test_arp_spoof_doesnt_block_normal_traffic fails with AttributeError: 'NoneType' object has no attribute 'splitlines'

Bug #1672607 reported by Ihar Hrachyshka on 2017-03-14
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
High
Or Idgar

Bug Description

http://logs.openstack.org/03/444603/5/check/gate-neutron-dsvm-functional-ubuntu-xenial/52405e2/testr_results.html.gz

Traceback (most recent call last):
  File "neutron/tests/base.py", line 116, in func
    return f(self, *args, **kwargs)
  File "neutron/tests/functional/agent/test_ovs_flows.py", line 182, in test_arp_spoof_doesnt_block_normal_traffic
    self._setup_arp_spoof_for_port(self.src_p.name, [self.src_addr])
  File "neutron/tests/functional/agent/test_ovs_flows.py", line 309, in _setup_arp_spoof_for_port
    self.br_int, vif, details)
  File "neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py", line 916, in setup_arp_spoofing_protection
    bridge.set_allowed_macs_for_port(vif.ofport, mac_addresses)
  File "neutron/plugins/ml2/drivers/openvswitch/agent/openflow/ovs_ofctl/br_int.py", line 150, in set_allowed_macs_for_port
    in_port=port).splitlines()
AttributeError: 'NoneType' object has no attribute 'splitlines'

7 hits in 7 days.

Changed in neutron:
importance: Undecided → High
tags: added: functional-tests gate-failure ovs

The root cause is a segmentation fault in ovs itself:

2017-03-13T06:06:17.607Z|00002|daemon_unix(monitor)|ERR|1 crashes: pid 6301 died, killed (Segmentation fault), core dumped, restarting

but our code should be able to gracefully handle that.

Changed in neutron:
status: New → Confirmed

The segfault is tracked in other place, removing gate-failure tag.

tags: removed: gate-failure

The bug is to make the code failing more gracefully on a similar ovs crash.

tags: added: low-hanging-fruit
Changed in neutron:
assignee: nobody → omkar_telee (omkar-telee)
Changed in neutron:
assignee: omkar_telee (omkar-telee) → nobody
Or Idgar (oidgar) on 2017-07-03
Changed in neutron:
assignee: nobody → Or Idgar (oidgar)

Fix proposed to branch: master
Review: https://review.openstack.org/482996

Changed in neutron:
status: Confirmed → In Progress
Changed in neutron:
milestone: none → pike-rc1

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/482996
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers