ovsdb-monitor fails to connect to tcp port when vsctl driver is used

[Ihar Hrachyshka]

It can be spotted in some functional test runs where vsctl flavours of tests are triggered before any native flavored test enables the manager port for tcp. For example,

http://logs.openstack.org/18/441218/1/check/gate-neutron-dsvm-functional-ubuntu-xenial/08292fe/logs/dsvm-functional-logs/neutron.tests.functional.agent.l2.extensions.test_ovs_agent_qos_extension.TestOVSAgentQosExtension.test_policy_rule_delete_vsctl_.txt.gz#_2017-03-03_16_53_30_358

This is because of https://review.openstack.org/#/c/407813/ that assumed that we use native.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/441447
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6975e2a48e85a5f0f198e2af3e99bc06dd409eaa
Submitter: Jenkins
Branch: master

commit 6975e2a48e85a5f0f198e2af3e99bc06dd409eaa
Author: Terry Wilson <email address hidden>
Date: Fri Mar 3 14:00:39 2017 -0600

    Ensure ovsdb_connection enabled before calling monitor

    ovsdb-client monitor attempts to connect to ovs via the
    ovsdb_connection if it is set. Since it is set by default, we need
    to ensure that OVS is listening on the socket before calling
    ovsdb-client monitor.

    Closes-Bug: #1669893
    Depends-On: Ibde5417d005265d27e939ca29788c21f73b38980
    Change-Id: Ia34b9d599b522dd12ef088100c2b68a75a78d797

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/442799

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/442799
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ae20437e984d89600f111f5b338e1ec3825c2e03
Submitter: Jenkins
Branch: stable/ocata

commit ae20437e984d89600f111f5b338e1ec3825c2e03
Author: Terry Wilson <email address hidden>
Date: Fri Mar 3 14:00:39 2017 -0600

    Ensure ovsdb_connection enabled before calling monitor

    ovsdb-client monitor attempts to connect to ovs via the
    ovsdb_connection if it is set. Since it is set by default, we need
    to ensure that OVS is listening on the socket before calling
    ovsdb-client monitor.

    Closes-Bug: #1669893
    Depends-On: Ibde5417d005265d27e939ca29788c21f73b38980
    Change-Id: Ia34b9d599b522dd12ef088100c2b68a75a78d797
    (cherry picked from commit 6975e2a48e85a5f0f198e2af3e99bc06dd409eaa)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b1 development milestone.