[SRU] Infinite loop trying to delete deleted HA router
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Security Advisory |
Won't Fix
|
Undecided
|
Unassigned | ||
Ubuntu Cloud Archive |
Invalid
|
Undecided
|
Unassigned | ||
Mitaka |
Fix Released
|
High
|
Unassigned | ||
neutron |
Fix Released
|
Medium
|
Ann Taraday | ||
neutron (Ubuntu) |
Invalid
|
Medium
|
Unassigned | ||
Xenial |
Fix Released
|
High
|
Unassigned |
Bug Description
[Descriptoin]
When deleting a router the logfile is filled up. See full log - http://
I can see the error 'Error while deleting router c0dab368-
$ grep -r 'Error while deleting router c0dab368-
3343386
This _safe_router_
[1] https:/
[2] https:/
[3] https:/
[Test Case]
That's because race condition between neutron server and L3 agent, after neutron server deletes HA interfaces the L3 agent may sync a HA router without HA interface info (just need to trigger L708[1] after deleting HA interfaces and before deleting HA router). If we delete HA router at this time, this problem will happen. So test case we design is as below:
1, First update fixed package, and restart neutron-server by 'sudo service neutron-server restart'
2, Create ha_router
neutron router-create harouter --ha=True
3, Delete ports associated with ha_router before deleting ha_router
neutron router-port-list harouter |grep 'HA port' |awk '{print $2}' |xargs -l neutron port-delete
neutron router-port-list harouter
4, Update ha_router to trigger l3-agent to update ha_router info without ha_port into self.router_info
neutron router-update harouter --description=test
5, Delete ha_router this time
neutron router-delete harouter
[1] https:/
[Regression Potential]
The fixed patch [1] for neutron-server will no longer return ha_router which is missing ha_ports, so L488 will no longer have chance to call _safe_router_
Besides, this fixed patch has been in mitaka-eol branch now, and neutron-server mitaka package is based on neutron-8.4.0, so we need to backport it to xenial and mitaka.
$ git tag --contains 8c77ee6b20dd38c
mitaka-eol
[1] https:/
[2] https:/
Changed in neutron: | |
importance: | Undecided → Medium |
Changed in ossa: | |
status: | New → Incomplete |
Changed in neutron (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
description: | updated |
summary: |
- Infinite loop trying to delete deleted HA router + [SRU] Infinite loop trying to delete deleted HA router |
description: | updated |
tags: | added: sts sts-sru-needed |
description: | updated |
tags: | added: sru-sponsors |
tags: | removed: sru-sponsors |
Changed in neutron (Ubuntu Xenial): | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in neutron (Ubuntu): | |
status: | Triaged → Invalid |
Changed in cloud-archive: | |
status: | New → Invalid |
description: | updated |
tags: |
added: sts-sru-done removed: sts-sru-needed |
Changed in neutron: | |
status: | In Progress → Fix Released |
Fix proposed to branch: master /review. openstack. org/439185
Review: https:/