cleanup overrides of resource operations in ML2

[Kevin Benton]

In an effort to simplify the code-base and provide a consistent way to handle resource life-cycles. I think we should eliminate cases in the ML2 plugin where it is overriding a method of db_base_plugin_v2 where possible by leveraging the callback events for resources (BEFORE_CREATE/PRECOMMIT_CREATE/etc).

[Kevin Benton (kevinbenton)]

See https://review.openstack.org/#/q/topic:bug/1666424 for list of bugs

[Kevin Benton (kevinbenton)]

I mean for a list of patches.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/423584
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1f5ee0e8942e4b77a89a00ee0249de5d5014e2bc
Submitter: Jenkins
Branch: master

commit 1f5ee0e8942e4b77a89a00ee0249de5d5014e2bc
Author: Kevin Benton <email address hidden>
Date: Fri Jan 20 21:23:05 2017 -0800

    Get rid of ML2 inheritance of delete_network

    In an effort to simplify the codebase, this eliminates
    all of the custom code in the ML2 delete_network
    method and leverages registry callbacks for network
    events.

    The only purpose of the remaining inheritance of the
    method is to leave the transaction guard on.

    Partial-Bug: #1666424
    Change-Id: Ib7d1c2081654dda82b5e015c71d20f378f3308f7

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/428774
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=31fa23d84c9054fb4cfebccef953bf6839698a1d
Submitter: Jenkins
Branch: master

commit 31fa23d84c9054fb4cfebccef953bf6839698a1d
Author: Kevin Benton <email address hidden>
Date: Fri Feb 3 07:16:33 2017 -0800

    Get rid of delete_subnet method in ML2

    This method has grown to be one of the most hideous methods in
    Neutron. It's well past Icehouse so it's time to address the
    REVISIT and get rid of it entirely. :)

    This patch refactors ML2 and the db_base_plugin_v2 delete_subnet
    method so ML2 can perform its ML2-specific tasks with callbacks
    and db_base_plugin_v2 can handle the rest.

    Partial-Bug: #1666424
    Change-Id: Ie29acfbe323b60205ade9d660f7497f5bf4a35ca

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/454832

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/454839

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/454877

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/454877
Reason: I got my results, thanks.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/454839
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4a96b962b560733a90b24ae10290e3d835d448e3
Submitter: Jenkins
Branch: stable/newton

commit 4a96b962b560733a90b24ae10290e3d835d448e3
Author: Kevin Benton <email address hidden>
Date: Fri Feb 3 07:16:33 2017 -0800

    Get rid of delete_subnet method in ML2

    This method has grown to be one of the most hideous methods in
    Neutron. It's well past Icehouse so it's time to address the
    REVISIT and get rid of it entirely. :)

    This patch refactors ML2 and the db_base_plugin_v2 delete_subnet
    method so ML2 can perform its ML2-specific tasks with callbacks
    and db_base_plugin_v2 can handle the rest.

    Backport justification: it solves bug 1672701.

    Conflicts:
          neutron/db/db_base_plugin_v2.py
          neutron/plugins/ml2/plugin.py
          neutron/tests/unit/plugins/ml2/test_plugin.py

    Partial-Bug: #1666424
    Change-Id: Ie29acfbe323b60205ade9d660f7497f5bf4a35ca
    (cherry picked from commit 31fa23d84c9054fb4cfebccef953bf6839698a1d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/454832
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1eab4b445a534fa968b240c00333646081f9501c
Submitter: Jenkins
Branch: stable/ocata

commit 1eab4b445a534fa968b240c00333646081f9501c
Author: Kevin Benton <email address hidden>
Date: Fri Feb 3 07:16:33 2017 -0800

    Get rid of delete_subnet method in ML2

    This method has grown to be one of the most hideous methods in
    Neutron. It's well past Icehouse so it's time to address the
    REVISIT and get rid of it entirely. :)

    This patch refactors ML2 and the db_base_plugin_v2 delete_subnet
    method so ML2 can perform its ML2-specific tasks with callbacks
    and db_base_plugin_v2 can handle the rest.

    Backport justification: it solves bug 1672701.

    Partial-Bug: #1666424
    Change-Id: Ie29acfbe323b60205ade9d660f7497f5bf4a35ca
    (cherry picked from commit 31fa23d84c9054fb4cfebccef953bf6839698a1d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/435601
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b9b598040da1b8d3e860b39d9027c10f8576ee33
Submitter: Jenkins
Branch: master

commit b9b598040da1b8d3e860b39d9027c10f8576ee33
Author: Kevin Benton <email address hidden>
Date: Fri Feb 17 13:20:22 2017 -0800

    Move notify_security_groups_member_updated to callback

    This moves the notify_security_groups_member_updated calls
    outside of ML2 into a callback in the security groups RPC
    base.

    This will allow us to ultimately stop overriding the
    create/delete/update port inheritance in ML2.

    This results in a small behavior change internally for bulk
    port creation operations where the notifier will be called
    once for each port rather than once for all ports. We can
    revisit this in the future if it turns out to be problematic
    but right now the bulk port creation API is rarely anyway
    since it's mostly a hidden feature (lack of client support).

    Partial-Bug: #1666424
    Change-Id: I344a82d5a1a8bf1e2b3f6a3ce7725682bb03b007