neutron

QoS drivers need to implement a precommit for the actions

Bug #1657381 reported by Miguel Angel Ajo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Rodolfo Alonso

Bug Description

Some backends like ODL use a logging and sync mechanism that would benefit from exposing a precommit for all the exposed driver actions.

We should implement a create_policy_precommit, update_policy_precommit, delete_policy_precommit.

Tags: qos
Miguel Angel Ajo (mangelajo)
Changed in neutron:
status: New → In Progress
importance: Undecided → Medium
milestone: none → ocata-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/421818

Revision history for this message
Miguel Angel Ajo (mangelajo) wrote :

I logged this bug after talking to Isaku Yamahata.

I believe I still don't understand what's the benefit of having a precommit within transaction call if we don't expect the calls to throw any exception and stop the transaction.

Revision history for this message
Miguel Angel Ajo (mangelajo) wrote :

https://review.openstack.org/#/c/421818/

Armando Migliaccio (armando-migliaccio)
Changed in neutron:
milestone: ocata-3 → ocata-rc1
Armando Migliaccio (armando-migliaccio)
Changed in neutron:
milestone: ocata-rc1 → pike-1
Revision history for this message
Miguel Angel Ajo (mangelajo) wrote :

There are some questions we need to clarify which happened during review and make me think which such mechanisms are not really necessary:

@Iwamoto, see latest questions on:
https://review.openstack.org/#/c/421818/

I'd be glad to re-open it if we need to, of course.

Changed in neutron:
status: In Progress → Incomplete
milestone: pike-1 → none
assignee: Miguel Angel Ajo (mangelajo) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Miguel Angel Ajo (<email address hidden>) on branch: master
Review: https://review.openstack.org/421818

OpenStack Infra (hudson-openstack)
Changed in neutron:
assignee: nobody → Miguel Angel Ajo (mangelajo)
status: Incomplete → In Progress
OpenStack Infra (hudson-openstack)
Changed in neutron:
assignee: Miguel Angel Ajo (mangelajo) → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/421818
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=45fd7eef6eb0fe5c760338953c91c046730f153c
Submitter: Jenkins
Branch: master

commit 45fd7eef6eb0fe5c760338953c91c046730f153c
Author: Miguel Angel Ajo <email address hidden>
Date: Wed Jan 18 11:46:34 2017 +0100

    Add precommit calls to the QoSDriver class

    Added create, update and delete precommit calls for QoS
    driver, to be used by some out-of-tree backends.

    Co-Authored-By: Miguel Angel Ajo <email address hidden>
    Co-Authored-By: Rodolfo Alonso Hernandez <email address hidden>

    Closes-Bug: #1657381
    Change-Id: I44dd7e049eab054363063021f07ade81ef2d1a90

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b2

This issue was fixed in the openstack/neutron 11.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.