Backport: Revision is not increased when updating "network router:external"

[Gena]

Try to update the network field router:external we expect the revision number to be increased, but it doesn't.
Run "neutron net-update moshe --router:external=True" command for new network.
The field router-external is updated but the revision number is not increased.

Tested on Newton version (10)

[Reedip (reedip-banerjee-deactivatedaccount)]

Hi Gena,
Thanks for the bug but we would need more information for the resolution of the bug.

Can you please provide more information , as per the policy given in the below link ??

http://docs.openstack.org/developer/neutron/policies/bugs.html#bug-screening-best-practices

[Gena (gcheresh)]

Added the logs in pastebin where you can see that the revision number before and after the operation of update field in the network didn't change.

http://pastebin.com/RNdN7m2s

Steps to reproduce:
Run "neutron net-update moshe --router:external=True"

Expected: The revision number should increase after performing update of router:external field of the network

Actual result: The revision number is the same

[Boden R (boden)]

I cannot reproduce this with neutron/master::

----

ubuntu@diag:~/devstack$ neutron net-show net1
+---------------------------+--------------------------------------+
| Field | Value |
+---------------------------+--------------------------------------+
| admin_state_up | True |
| availability_zone_hints | |
| availability_zones | |
| created_at | 2017-01-12T14:12:57Z |
| description | |
| id | 0b60bfa7-08e6-4ce6-8a71-a51aa6065b4c |
| ipv4_address_scope | |
| ipv6_address_scope | |
| mtu | 1450 |
| name | net1 |
| port_security_enabled | True |
| project_id | db997839c32842fab5fe7f390e8015c8 |
| provider:network_type | vxlan |
| provider:physical_network | |
| provider:segmentation_id | 47 |
| revision_number | 3 |
| router:external | False |
| shared | False |
| status | ACTIVE |
| subnets | |
| tags | |
| tenant_id | db997839c32842fab5fe7f390e8015c8 |
| updated_at | 2017-01-12T14:12:57Z |
+---------------------------+--------------------------------------+
ubuntu@diag:~/devstack$ neutron net-update net1 --router:external=True
Updated network: net1
ubuntu@diag:~/devstack$ neutron net-show net1
+---------------------------+--------------------------------------+
| Field | Value |
+---------------------------+--------------------------------------+
| admin_state_up | True |
| availability_zone_hints | |
| availability_zones | |
| created_at | 2017-01-12T14:12:57Z |
| description | |
| id | 0b60bfa7-08e6-4ce6-8a71-a51aa6065b4c |
| ipv4_address_scope | |
| ipv6_address_scope | |
| is_default | False |
| mtu | 1450 |
| name | net1 |
| port_security_enabled | True |
| project_id | db997839c32842fab5fe7f390e8015c8 ...

[Reedip (reedip-banerjee-deactivatedaccount)]

Cant replicate in stable/newton

[outofmemory@localhost devstack]$ neutron net-create Test2
neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead.
neutroCreated a new network:
+---------------------------+--------------------------------------+
| Field | Value |
+---------------------------+--------------------------------------+
| admin_state_up | True |
| availability_zone_hints | |
| availability_zones | |
| created_at | 2017-01-12T15:25:27Z |
| description | |
| id | abfabc8a-7127-4bd3-83e8-205cd7f1d676 |
| ipv4_address_scope | |
| ipv6_address_scope | |
| mtu | 1450 |
| name | Test2 |
| port_security_enabled | True |
| project_id | 27ef7aeb8bca47dc823f294fa2a3ec2e |
| provider:network_type | vxlan |
| provider:physical_network | |
| provider:segmentation_id | 75 |
| qos_policy_id | |
| revision_number | 3 |
| router:external | False |
| shared | False |
| status | ACTIVE |
| subnets | |
| tags | |
| tenant_id | 27ef7aeb8bca47dc823f294fa2a3ec2e |
| updated_at | 2017-01-12T15:25:27Z |
+---------------------------+--------------------------------------+
[outofmemory@localhost devstack]$ neutron net-update Test2 --router:external=True
neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead.
Updated network: Test2
[outofmemory@localhost devstack]$ neutron net-show test2
neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead.
+---------------------------+--------------------------------------+
| Field | Value |
+---------------------------+--------------------------------------+
| admin_state_up | True |
| availability_zone_hints | |
| availability_zones | |
| created_at | 2017-01-12T15:25:27Z |
| description | |
| id | abfabc8a-7127-4bd3-83e8-205cd7f1d676 |
| ipv4_address_scope | |
| ipv6_address_scope | ...

[Boden R (boden)]

Marked as incomplete as per updates above; we are unable to reproduce.

Perhaps there's additional details the defect creator can provide that would help us reproduce. If so please add them and set the bug as NEW again.

Thanks

[Boden R (boden)]

Kevin Benton mentioned this may be a dup of [1]. I'm trying a few more things to see if I can repro + determine addition details.

[1] https://bugs.launchpad.net/neutron/+bug/1642517

[Boden R (boden)]

I was able to reproduce this with stable/newton.

As mentioned by Kevin, the fix is likely that of [1]. However the backporting of [1] isn't straight forward and therefore I didn't verify a backported version of [1] fixes this issue with newton.

I'm going to assume [1] will in fact fix this issue and turn this bug into an ask to backport it. Obviously that effort will involve verifying a backported version of [1] does in fact fix this issue.

[1] https://bugs.launchpad.net/neutron/+bug/1642517

[Gena (gcheresh)]

I have 2 similar issues with the non updated revision.
When updating QoS network policy and QoS port policy the revision is not updated as well.

Should I open 2 different bugs for it or is this one is enough?

[Gena (gcheresh)]

Those 3 tests are actually the automation tests we run and fail in neutron git

[Lujin Luo (luo-lujin)]

Hi Gena, I think Kevin just pushed a patch to backport the 3 bugs you mentioned. Please check https://review.openstack.org/#/c/420793/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/420793
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=570f6e46f54abf4322c7536bab4cc1ae2c40307f
Submitter: Jenkins
Branch: stable/newton

commit 570f6e46f54abf4322c7536bab4cc1ae2c40307f
Author: Lujin <email address hidden>
Date: Mon Nov 21 18:19:04 2016 +0900

    Add missing revises_on_change attribute

    This patch adds revises_on_change attribute to the following models
    and API tests to ensure the correct behaviour:

    ExternalNetwork (Network)
    RouterExtraAttributes (Router)
    QosPortPolicyBinding (Port)
    QosNetworkPolicyBinding (Network)
    PortBindingPort (Port)
    SegmentHostMapping (Network Segment)

    Conflicts: (file locations differed)
     neutron/db/models/external_net.py
     neutron/db/models/l3_attrs.py
     neutron/db/models/portbinding.py
     neutron/db/models/segment.py

    Closes-Bug: #1642517
    Closes-Bug: #1655917
    Change-Id: I8bda9fc940e99d18bab2b4229198374f1cabf84b

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.2.0 release.