l3 rpc handler not checking for UNBOUND with host_id

[Kevin Benton]

If a binding fails to commit after a host_id is set on a port, the port will have a host_id with a vif type of 'unbound'. In this case the L3 RPC handler should be trying to update the port again as it would when the binding had changed the vif type to binding_failed. However, it currently doesn't due to a bad conditional[1].

1. https://github.com/openstack/neutron/blob/5254f0ab60d46cabdace6d59ce50ca05568a87d5/neutron/api/rpc/handlers/l3_rpc.py#L141-L142

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/409314

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/409314
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a5a8a37344f6d193886ae8d047664aef76920ed8
Submitter: Jenkins
Branch: master

commit a5a8a37344f6d193886ae8d047664aef76920ed8
Author: Kevin Benton <email address hidden>
Date: Fri Dec 9 11:49:09 2016 -0800

    Check for unbound ports in L3 RPC handler

    The handler was making the incorrect assumption that once a
    host_id was set, a port which failed to bind could only be in
    the 'binding_failed' state. So it would not try to rebind ports
    that encountered an exeption during port binding commit that left
    them in the unbound state.

    Change-Id: I28bbeda5fed4275ea38e27308518f89df9ab4eff
    Closes-Bug: #1648879

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/422035

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/422037

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/422037
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c361055021e5f81142eee1d8aeb0bf786a5692e6
Submitter: Jenkins
Branch: stable/mitaka

commit c361055021e5f81142eee1d8aeb0bf786a5692e6
Author: Kevin Benton <email address hidden>
Date: Fri Dec 9 11:49:09 2016 -0800

    Check for unbound ports in L3 RPC handler

    The handler was making the incorrect assumption that once a
    host_id was set, a port which failed to bind could only be in
    the 'binding_failed' state. So it would not try to rebind ports
    that encountered an exeption during port binding commit that left
    them in the unbound state.

    Change-Id: I28bbeda5fed4275ea38e27308518f89df9ab4eff
    Closes-Bug: #1648879
    (cherry picked from commit a5a8a37344f6d193886ae8d047664aef76920ed8)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/422035
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=51f9ea667af74bae7dd6c61fd3a9e6f8b2e1b862
Submitter: Jenkins
Branch: stable/newton

commit 51f9ea667af74bae7dd6c61fd3a9e6f8b2e1b862
Author: Kevin Benton <email address hidden>
Date: Fri Dec 9 11:49:09 2016 -0800

    Check for unbound ports in L3 RPC handler

    The handler was making the incorrect assumption that once a
    host_id was set, a port which failed to bind could only be in
    the 'binding_failed' state. So it would not try to rebind ports
    that encountered an exeption during port binding commit that left
    them in the unbound state.

    Change-Id: I28bbeda5fed4275ea38e27308518f89df9ab4eff
    Closes-Bug: #1648879
    (cherry picked from commit a5a8a37344f6d193886ae8d047664aef76920ed8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 8.4.0 release.