Protocol parameters not validated when updating firewall rule

Bug #1646428 reported by Ha Van Tu
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Ha Van Tu

Bug Description

When we create an ICMP firewall rule with port range parameters, there will be an error from Neutron server.
However, when we create a TCP firewall rule with port range parameters, then edit this rule to the ICMP one, there is not any error from Neutron server.
We need to check before updating firewall rule.

Tags: fwaas
Ha Van Tu (tuhv)
Changed in neutron:
assignee: nobody → Ha Van Tu (tuhv)
tags: added: neutron-fwaas
tags: added: fwaas
removed: neutron-fwaas
summary: - [neutron-fwaas] Not validate protocol parameters when updating firewall
- rule
+ Not validate protocol parameters when updating firewall rule
summary: - Not validate protocol parameters when updating firewall rule
+ Protocol parameters not validated when updating firewall rule
Revision history for this message
Yushiro FURUKAWA (y-furukawa-2) wrote :

I could reproduce this result. I think it's a bug. Thanks for your reporting!!

Nguyen Phuong An (annp)
Changed in neutron:
status: New → Incomplete
status: Incomplete → New
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/407311

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/407311
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=37709b3e99eb29f359b4ed744a0fe691f24a3229
Submitter: Jenkins
Branch: master

commit 37709b3e99eb29f359b4ed744a0fe691f24a3229
Author: Ha Van Tu <email address hidden>
Date: Tue Dec 6 12:19:40 2016 +0700

    Adding validation protocol parameters when updating firewall rules

    This patch adding validation protocol parameter when updating firewall
    rules to prevent updating ICMP rule with "destination_port" or "source_port".

    Change-Id: Ieb2ac42e009f08f4708afb3edc2b2e7ae01af06d
    Closes-Bug: #1646428

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-fwaas 10.0.0.0b2

This issue was fixed in the openstack/neutron-fwaas 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.