Migrating HA routers to Legacy doesn't update interface's device_owner

[John Schwarz]

Patch I322c392529c04aca2448fd957a35f4908b323449 added a new device_owner for HA interfaces between a router and an internal subnet, which is used to differentiate it from normal, non-HA interfaces. However, when migrating a router from HA to legacy, the device_owner isn't switched back to its non-HA counterpart. This can cause migration of the router to DVR to not work properly as the snat interface isn't created.

A log and reproducible can be found in [1].

[1]: http://paste.openstack.org/show/590804/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/404215

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/404215
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4c41a259c93e326d5635164047c72c9de207fde5
Submitter: Jenkins
Branch: master

commit 4c41a259c93e326d5635164047c72c9de207fde5
Author: John Schwarz <email address hidden>
Date: Tue Nov 29 15:11:41 2016 +0200

    Migrate device_owner for router's interface

    When migrating a HA router to legacy, the router's interface (whose
    device_owner is network:ha_router_replicated_interface) isn't changed
    to network:router_interface. This means that certain actions (such as
    trying to use 'neutron router-interface-delete' and migrating the router
    to DVR) won't work (since a router interface of the appropriate type
    can't be found and an SNAT port won't be created, respectively). This
    patch takes care of the needed migration.

    Closes-Bug: #1645716
    Change-Id: I0c18ccf08ddfa57fde9b5ac331101497079bd330

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/405151

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/405151
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cd8b6d422826cab0337432c77aa3dd1c317bec6b
Submitter: Jenkins
Branch: stable/newton

commit cd8b6d422826cab0337432c77aa3dd1c317bec6b
Author: John Schwarz <email address hidden>
Date: Tue Nov 29 15:11:41 2016 +0200

    Migrate device_owner for router's interface

    When migrating a HA router to legacy, the router's interface (whose
    device_owner is network:ha_router_replicated_interface) isn't changed
    to network:router_interface. This means that certain actions (such as
    trying to use 'neutron router-interface-delete' and migrating the router
    to DVR) won't work (since a router interface of the appropriate type
    can't be found and an SNAT port won't be created, respectively). This
    patch takes care of the needed migration.

    Closes-Bug: #1645716
    Change-Id: I0c18ccf08ddfa57fde9b5ac331101497079bd330
    (cherry picked from commit 4c41a259c93e326d5635164047c72c9de207fde5)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.2.0 release.