"get_local_port_mac" in ovs_lib uses an only Linux command, brokes Windows compatibility

Bug #1644878 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Rodolfo Alonso

Bug Description

neutron/agent/common/ovs_lib:OVSBridge is mented to be compatible both for Linux and Windows.

In function "get_local_port_mac", the IP Linux lib is called, instead of the ip_lib wrapper in neutron/agent/common.

The solution to this problem is:
- To call the ip_lib in neutron/agent/common.
- To write the function to read the MAC address in the IPDevice class implementation for Windows.

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
description: updated
Changed in neutron:
status: New → Confirmed
importance: Undecided → Medium
tags: added: ovs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/403799

Changed in neutron:
status: Confirmed → In Progress
summary: - "get_local_port_mac" in ovs_lib uses an only Linux command, brakes
+ "get_local_port_mac" in ovs_lib uses an only Linux command, brokes
Windows compatibility
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/403804

Changed in neutron:
milestone: none → ocata-rc1
tags: added: ocata-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/403799
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=18e2e2def5bd1c28e6d017c0de674cda7683e14a
Submitter: Jenkins
Branch: master

commit 18e2e2def5bd1c28e6d017c0de674cda7683e14a
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Nov 28 16:33:44 2016 +0000

    Add IPLink class to Windows ip_lib implementation

    This new class is used to read the link address from
    a network device.

    Partial-Bug: #1644878
    Change-Id: Ieeaa1d3633b942e549c0513ca7360c0a91d10d04

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/403804
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=39567df190b0e46706d7bab32c58f86ee8786aa1
Submitter: Jenkins
Branch: master

commit 39567df190b0e46706d7bab32c58f86ee8786aa1
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Nov 28 16:48:22 2016 +0000

    Fix broken Windows compatibility in ovs_lib

    This patch changes the ip_lib used. Substitutes the
    the Linux implementation for the generic wrapper.

    Closes-Bug: #1644878
    Change-Id: Ida1b3586d8d6b5fda69286aa1428d31d16010d71

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.0.0rc1

This issue was fixed in the openstack/neutron 10.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.