neutron devstack plugin enables q-trunk depending on rally

[YAMAMOTO Takashi]

it enables q-trunk if rally devstack plugin is enabled.

i wanted to use neutron devstack plugin to configure qos plugin. [1]
i was surprised that it enables q-trunk.

[1] https://github.com/openstack/networking-midonet/blob/691f8490317f36ec2c629c9a397c09eebf7638bd/devstack/README.rst#qos

[Victor Morales (electrocucaracha)]

Hi Yamamoto,

Could you include the local.conf for this bug? I'm trying to reproduce this in my environment. Is this behavior only present using midonet?

[YAMAMOTO Takashi (yamamoto)]

Victor,

it isn't midonet specific. just "enable_plugin" neutron and rally, and see q-trunk is enabled.

my local.conf has too many midonet-specific development-only things.
i can provide it but i guess it isn't so useful.

[YAMAMOTO Takashi (yamamoto)]

i provided a feedback

[Kevin Benton (kevinbenton)]

That's because we have rally scenarios that exercise the trunk plugin. https://github.com/openstack/neutron/blob/master/rally-jobs/neutron-neutron.yaml#L308

What would you like to change?

[YAMAMOTO Takashi (yamamoto)]

Kevin,

i want to make it not to enable q-trunk silently.
rally job can enable it explicitly instead.

[YAMAMOTO Takashi (yamamoto)]

feedback provided

[YAMAMOTO Takashi (yamamoto)]

Victor,

an example config:
http://logs.openstack.org/40/342540/28/experimental/gate-networking-midonet-v2-rally-dsvm-ubuntu-xenial-nv/79e4255/logs/localrc.txt.gz

[YAMAMOTO Takashi (yamamoto)]

https://review.openstack.org/#/c/409604/

[YAMAMOTO Takashi (yamamoto)]

Satyanarayana,

i submitted project-config change.
but please feel free to take this over if you want to work on this.

[Armando Migliaccio (armando-migliaccio)]

I guess I did not account for the fact that other projects may still want to enable neutron plugin but hand pick what extension to load. It should be possible to switch the extension back off, but at least keep this in our control and I personally disagree with the project-config change.

[Armando Migliaccio (armando-migliaccio)]

Satyanarayana: if you like I can fix this for you, since I was the one who created the mishap in the first place :)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/411291

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/411297

[YAMAMOTO Takashi (yamamoto)]

Satyanarayana,

i submitted a new set of patches.
but feel free to take it back anytime if you want.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/415422

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/411291
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8ef0979700afc90634535b6991975ade639324d5
Submitter: Jenkins
Branch: master

commit 8ef0979700afc90634535b6991975ade639324d5
Author: YAMAMOTO Takashi <email address hidden>
Date: Thu Dec 15 21:26:53 2016 +0900

    gate_hook: Add a no-op rally case

    This is the first step of the following plan:

        1. make neutron's gate_hook accept "rally" but do nothing.
        2. make project-config change to consume the gate_hook
        3. make the rest of neutron change

    Partial-Bug: #1643451
    Change-Id: I0a309272ec46b8477fe57eeb676a5cd850e4d60b

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/415422
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=680e1448b853a1c7fe93746b5220fdb03071b2ff
Submitter: Jenkins
Branch: stable/newton

commit 680e1448b853a1c7fe93746b5220fdb03071b2ff
Author: YAMAMOTO Takashi <email address hidden>
Date: Thu Dec 15 21:26:53 2016 +0900

    gate_hook: Add a no-op rally case

    This is the first step of the following plan:

        1. make neutron's gate_hook accept "rally" but do nothing.
        2. make project-config change to consume the gate_hook
        3. make the rest of neutron change

    Partial-Bug: #1643451

    (cherry picked from commit 8ef0979700afc90634535b6991975ade639324d5)
    Change-Id: I0a309272ec46b8477fe57eeb676a5cd850e4d60b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/417524

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/417524
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=962de7f5bd8d2a59c153fc198f13f112f5464551
Submitter: Jenkins
Branch: stable/mitaka

commit 962de7f5bd8d2a59c153fc198f13f112f5464551
Author: YAMAMOTO Takashi <email address hidden>
Date: Thu Dec 15 21:26:53 2016 +0900

    gate_hook: Add a no-op rally case

    This is the first step of the following plan:

        1. make neutron's gate_hook accept "rally" but do nothing.
        2. make project-config change to consume the gate_hook
        3. make the rest of neutron change

    Partial-Bug: #1643451
    (cherry picked from commit 8ef0979700afc90634535b6991975ade639324d5)

    Conflicts:
     neutron/tests/contrib/gate_hook.sh

    Change-Id: I0a309272ec46b8477fe57eeb676a5cd850e4d60b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/417884

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/411297
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b1405cbe1ec77bab5dfa0e810813951b3e0e8aa4
Submitter: Jenkins
Branch: master

commit b1405cbe1ec77bab5dfa0e810813951b3e0e8aa4
Author: YAMAMOTO Takashi <email address hidden>
Date: Thu Dec 15 21:42:07 2016 +0900

    Use gate_hook to enable q-trunk for rally.

    Instead of making devstack enable it, because it can have
    undesired effects for other rally-using gate jobs.
    (See Closes-Bug for an example)

    Closes-Bug: #1643451
    Change-Id: Id971432955196a7d5f64c598aeebf1a7bc245321

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/417884
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=13af01167180758a25429ec24668ab8b63fe662f
Submitter: Jenkins
Branch: stable/newton

commit 13af01167180758a25429ec24668ab8b63fe662f
Author: YAMAMOTO Takashi <email address hidden>
Date: Thu Dec 15 21:42:07 2016 +0900

    Use gate_hook to enable q-trunk for rally.

    Instead of making devstack enable it, because it can have
    undesired effects for other rally-using gate jobs.
    (See Closes-Bug for an example)

    Closes-Bug: #1643451

    (cherry picked from commit b1405cbe1ec77bab5dfa0e810813951b3e0e8aa4)
    Change-Id: Id971432955196a7d5f64c598aeebf1a7bc245321

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.2.0 release.