Deprecate and remove send_arp_for_ha option

[Ihar Hrachyshka]

It puzzles me why we would want to have it configurable. Having it = 0 is just plain bad (it breaks a floating IP roaming around HA routers), having it = 1 may be unsafe if clients miss the update, having it more than 3 (the default) is probably wasteful. That makes me think that maybe we should not have it in the first place.

The patch that introduced the option also introduced the feature itself, and does not provide any clue around why we would need it: https://review.openstack.org/#/c/12037/

Maybe the option is in the tree because, in Assaf's words, "we're a bunch of lazy developers that like to shift the responsibility to our poor users that have to deal with thousands of configuration options".

I suggest we just move with deprecation and removal here.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/394552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/394552
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6b59cc72a4eec9fabaf90f0a0a86b4781a68df17
Submitter: Jenkins
Branch: master

commit 6b59cc72a4eec9fabaf90f0a0a86b4781a68df17
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Nov 7 17:30:18 2016 +0000

    Deprecate send_arp_for_ha option

    It puzzles me why we would want to have it configurable. Having it = 0
    is just plain bad (it breaks a floating IP roaming around HA routers),
    having it = 1 may be unsafe if clients miss the update, having it more
    than 3 (the default) is probably wasteful. That makes me think that
    maybe we should not have it in the first place.

    The patch that introduced the option also introduced the feature itself,
    and does not provide any clue around why we would need it:
    I125dbc57b90027dc5e99ff0a5d6877843a0b02a5

    Maybe the option is in the tree because, in Assaf Muller's words, "we're
    a bunch of lazy developers that like to shift the responsibility to our
    poor users that have to deal with thousands of configuration options".

    I suggest we just move with deprecation and removal here.

    Change-Id: I9d12b8f4c25ddf91312153f236915c0c14302e2d
    Related-Bug: #1639879

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/457680

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/457680
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8bb94820bd1d95414047ae52165411fe818a8d0e
Submitter: Jenkins
Branch: master

commit 8bb94820bd1d95414047ae52165411fe818a8d0e
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Apr 18 07:54:45 2017 -0700

    Remove deprecated send_arp_for_ha option

    Now Neutron always sends three gARPs after address assigned to an
    interface.

    Change-Id: I0d44f4cc59e1675b20d0da329faf7fd3ab91acbf
    Closes-Bug: #1639879

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b2 development milestone.