L3 scheduler: make RouterL3AgentBinding always concurrently safe

Bug #1633042 reported by John Schwarz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
John Schwarz

Bug Description

Changeset I3447ea5bcb7c57365c6f50efe12a1671e86588b3 added a binding_index column to the RouterL3AgentBinding table, which is unique with the router_id. However, the current logic isn't concurrent safe as some concurrent cases can raise a DBDuplicateEntry (if the same binding_index is being used by 2 different workers).

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
Brian Haley (brian-haley) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/365326
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1e195afaf12cbb426a356a11cacfe45f04bd43a2
Submitter: Jenkins
Branch: master

commit 1e195afaf12cbb426a356a11cacfe45f04bd43a2
Author: John Schwarz <email address hidden>
Date: Sun Sep 4 13:48:58 2016 +0300

    L3 scheduler: add retry indicators for bind_router

    Change I3447ea5bcb7c57365c6f50efe12a1671e86588b3 added a binding_index
    to the RouterL3AgentBinding table. In certain (concurrent) cases, a row
    with the same binding_index might be used twice, which will raise
    DBDuplicateEntry. However, that change didn't retry on this case at all
    code-paths, so this patch rectifies this issue.

    Closes-Bug: #1633042
    Change-Id: I228b0084a8e7c48e78bc2ea6a3fccf7437210e73

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.0.0b2

This issue was fixed in the openstack/neutron 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.