L3: missing registry callback notification at Router Interface creation

[Thomas Morin]

The code triggering a ROUTER_INTERFACE AFTER_CREATE registry notification is not ran if the Router to which an interface is added has no gateway connected.

[1] https://github.com/openstack/neutron/blob/930655cf57de523181b2d59bb4428b9f23991cce/neutron/db/l3_dvr_db.py#L427 )

This behavior is problematic for components that need to rely on this functionality, and not consistent with what the non-DVR code does [2].

[2] https://github.com/openstack/neutron/blob/f4ba9ea8ac18fabac80cb0443bc18d9f950482b3/neutron/db/l3_db.py#L815

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/381165

[Thomas Morin (tmmorin-orange)]

Changed the title to reflect the case that the bug is in code used also apparently used by non-DVR setups.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/382385

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/381165
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fb530389ad7401b50b2cd6fa0a2570d6e9bafe59
Submitter: Jenkins
Branch: master

commit fb530389ad7401b50b2cd6fa0a2570d6e9bafe59
Author: Thomas Morin <email address hidden>
Date: Mon Oct 3 16:41:57 2016 +0200

    L3 DVR: always notify on ROUTER_INTERFACE AFTER_CREATE

    With this change the L3 DVR code for add_router_interface
    will always generate ROUTER_INTERFACE AFTER_CREATE notifications,
    even in the absence of a gateway on the router.

    Change-Id: I2eae49b06cad0c42950ac76f1db7ea6e37e308b9
    Closes-Bug: 1629861

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/382385
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1fcc05f8f303c7ee35e025fda67c6ef264269acd
Submitter: Jenkins
Branch: stable/newton

commit 1fcc05f8f303c7ee35e025fda67c6ef264269acd
Author: Thomas Morin <email address hidden>
Date: Mon Oct 3 16:41:57 2016 +0200

    L3 DVR: always notify on ROUTER_INTERFACE AFTER_CREATE

    With this change the L3 DVR code for add_router_interface
    will always generate ROUTER_INTERFACE AFTER_CREATE notifications,
    even in the absence of a gateway on the router.

    Change-Id: I2eae49b06cad0c42950ac76f1db7ea6e37e308b9
    Closes-Bug: 1629861
    (cherry picked from commit fb530389ad7401b50b2cd6fa0a2570d6e9bafe59)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.0.0b1 development milestone.