Concurrent security groups creation fails with DBDuplicateEntry

[Oleg Bondarev]

 - create_security_group() is wrapped with a db retry decorator
 - it calls _ensure_default_security_group() to create a default security group for a tenant if one does not exist
 - _ensure_default_security_group() in turn calls back to create_security_group() to create a default security group
 - due to concurrency the creation of default security group my fail with DBDuplicateEntry
 - this is retried for max attempts and the request eventually fails

Traceback: http://paste.openstack.org/show/581903/
Example of failed job in rally: http://logs.openstack.org/04/371604/1/check/gate-rally-dsvm-neutron-rally/b1c384d/

[Oleg Bondarev (obondarev)]

Fix: https://review.openstack.org/#/c/373108/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373108
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5ad5d103ad02e2787a539c82b0efcbe51cfe857c
Submitter: Jenkins
Branch: master

commit 5ad5d103ad02e2787a539c82b0efcbe51cfe857c
Author: Oleg Bondarev <email address hidden>
Date: Tue Sep 20 12:54:50 2016 +0300

    Do not retry default security group creation

    No need to retry creation of a default security group - it will
    always fail with DBDuplicate

    Closes-Bug: #1625557
    Change-Id: I8af479ff9631851e7d78c4fc28e8363eda848775

[Armando Migliaccio (armando-migliaccio)]

Patch is being reverted.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373841

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373841
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=09d1185d24c30690358a9314c14fabaead2f4c78
Submitter: Jenkins
Branch: master

commit 09d1185d24c30690358a9314c14fabaead2f4c78
Author: Oleg Bondarev <email address hidden>
Date: Wed Sep 21 10:36:05 2016 +0300

    Do not retry default security group creation

    No need to retry creation of a default security group - it will
    always fail with DBDuplicate.
    The patch opens a transaction before calling to create_security_group()
    when creating default security group, thus avoiding db retries.

    Closes-Bug: #1625557
    Change-Id: Id15b55b097641325ac68275fe4bb3ebe93718cdd

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/374325

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374325
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=91d233e26bc4dc8f2e88ab6830b255a6f4394666
Submitter: Jenkins
Branch: stable/newton

commit 91d233e26bc4dc8f2e88ab6830b255a6f4394666
Author: Oleg Bondarev <email address hidden>
Date: Wed Sep 21 10:36:05 2016 +0300

    Do not retry default security group creation

    No need to retry creation of a default security group - it will
    always fail with DBDuplicate.
    The patch opens a transaction before calling to create_security_group()
    when creating default security group, thus avoiding db retries.

    Closes-Bug: #1625557
    Change-Id: Id15b55b097641325ac68275fe4bb3ebe93718cdd
    (cherry picked from commit 09d1185d24c30690358a9314c14fabaead2f4c78)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.0.0b1 development milestone.