_create_or_update_agent used by neutron-dynamic-routing

[Armando Migliaccio]

With change [1] we accidentally removed a private method, which is used by neutron-dynamic-routing. Furthermore, we tweaked the signature of the corresponding public method. This is really bad and should have not happened.

No point in crying over spilled milk, [3] shows us that damage is not as bad as it sounds, and does not justify a revert for [1], but this warrants an RC2 for dynamic-routing, whose unit tests are currently broken for RC1.

[1] https://review.openstack.org/#/c/367182/
[2] https://review.openstack.org/#/c/371680/
[3] http://codesearch.openstack.org/?q=create_or_update_agent&i=nope&files=&repos=

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/371742

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/371743

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/371742
Committed: https://git.openstack.org/cgit/openstack/neutron-dynamic-routing/commit/?id=b4c840d97b828c4f81c813f41f3de5f1355f2896
Submitter: Jenkins
Branch: master

commit b4c840d97b828c4f81c813f41f3de5f1355f2896
Author: Armando Migliaccio <email address hidden>
Date: Fri Sep 16 11:06:22 2016 -0700

    Stop using _create_or_update_agent

    There is a public method, use it instead!

    Change-Id: Ie076a2860a54c5e2958c16593c3f39f86353cd34
    Closes-bug: #1624496

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/371743
Reason: superseded by https://review.openstack.org/#/c/373471/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373471
Committed: https://git.openstack.org/cgit/openstack/neutron-dynamic-routing/commit/?id=ceac1a94a8a9400e7e46e7860f628215a8f56336
Submitter: Jenkins
Branch: stable/newton

commit ceac1a94a8a9400e7e46e7860f628215a8f56336
Author: Armando Migliaccio <email address hidden>
Date: Fri Sep 16 11:06:22 2016 -0700

    Stop using _create_or_update_agent

    There is a public method, use it instead!

    Closes-bug: #1624496

    (cherry picked from commit b4c840d97b828c4f81c813f41f3de5f1355f2896)

    Change-Id: Ie076a2860a54c5e2958c16593c3f39f86353cd34

    pep8: switched to neutron-lib hacking checks

    A recent hacking check landed in neutron broke the pep8 target for the
    repo. Using hacking checks from neutron is error prone.

    This patch switches the repo to checks from neutron-lib. It also skips
    N530 check because the repo still imports from neutron.*

    (cherry picked from commit fa11d9a0a5af3b9a9714bbfa82b6dc7b9f40e5df)

    Change-Id: I70ce6698a3f25af39917ec7bdf1a31a1d4cabf89

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-dynamic-routing 9.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-dynamic-routing 9.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-dynamic-routing 10.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-dynamic-routing 9.0.0 release.