AFTER_DELETE event for SECURITY_GROUP_RULE should contain sg_id

Bug #1621698 reported by Hong Hui Xiao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Hong Hui Xiao

Bug Description

In the notification of AFTER_DELETE event for SECURITY_GROUP_RULE, the security group rule is actually deleted from DB. There is no way for subscriber to know the latest information of related security group.

To be specific, dragonflow will maintain the security group version, and we are using revision_number in dragonflow now. The sg_rule_delete will bump the sg revision, which will only happen after the db transaction. dragonflow stores security group rule as part of security group. So, in the AFTER_DELETE event of SECURITY_GROUP_RULE, we don't know which security group is updated, if neutron don't pass the security group id.

We can query all security group and iterate their security group rules. But that is inefficient and it will be nice if neutron just pass the related security group id.

Hong Hui Xiao (xiaohhui)
Changed in neutron:
assignee: nobody → Hong Hui Xiao (xiaohhui)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/367728

Changed in neutron:
status: New → In Progress
John Schwarz (jschwarz)
Changed in neutron:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/367728
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3e25ee3e28e1832b8eb0474db1e980b75f377df1
Submitter: Jenkins
Branch: master

commit 3e25ee3e28e1832b8eb0474db1e980b75f377df1
Author: Hong Hui Xiao <email address hidden>
Date: Fri Sep 9 10:27:47 2016 +0800

    Add sg_id in the AFTER_DELETE event of sg_rule delete

    In the AFTER_DELETE of sg_rule delete, the sg_rule is actually deleted.
    This makes it impossible/hard to know which sg is affected.

    This patch add the sg_id in the event. And this patch will be used in [1].

    [1] https://review.openstack.org/#/c/367718

    Change-Id: Ibdef6a703913b74504e402d225b1a0dffadb7aff
    Closes-Bug: #1621698

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.0.0b2

This issue was fixed in the openstack/neutron 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.