test_trunk_manager functional test is unstable

[Jakub Libosvar]

Functional tests for trunk manager test connectivity while resource might not be ready yet because of asynchronous interaction with ovs. That means e.g. we want to remove subport from trunk and then test that port in trunk can't be accessed using vlan id from removed subport. Since it may take some time to ovs to completely remove plugging, some packets can still get through and fail the test.

A failure mode:

http://logs.openstack.org/36/335536/18/check/gate-neutron-dsvm-functional/4d0529d/testr_results.html.gz

[Armando Migliaccio (armando-migliaccio)]

I thought we had mitigated that by increasing the ICMP count, but it's good to nip this in the buds.

[Armando Migliaccio (armando-migliaccio)]

https://review.openstack.org/#/c/359399/

[Jakub Libosvar (libosvar)]

I see in the logs that we still send 1 icmp packet... http://logs.openstack.org/36/335536/18/check/gate-neutron-dsvm-functional/4d0529d/logs/dsvm-functional-logs/neutron.tests.functional.services.trunk.drivers.openvswitch.agent.test_trunk_manager.TrunkManagerTestCase.test_connectivity.txt.gz#_2016-08-23_13_34_54_487

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/359399
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2618726458d2cb75a39521bf9fd71c6bfd1c0c67
Submitter: Jenkins
Branch: master

commit 2618726458d2cb75a39521bf9fd71c6bfd1c0c67
Author: Jakub Libosvar <email address hidden>
Date: Tue Aug 23 15:45:25 2016 -0400

    functional: Make trunk tests more robust

    New methods for connection tester are introduced in this patch. They
    send certain amount of icmp packets and then compare the results, so we
    succeed in positive tests only when all packets were replied. We succeed
    in negative tests only when all packets were lost. Both approaches are
    wrapped by actively waiting for successful result so we don't fail in
    case where we test connectivity while resources are not wired yet.

    This change is a followup to https://review.openstack.org/#/c/335536/ to
    improve stability of its functional tests.

    Closes-Bug: 1617319

    Change-Id: I907ebd790f4ba3b4ecb0dce711c9f7d2c5244765

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0b3 development milestone.