neutron

OVO class attributes unrelated to OVO should start with underscore

Bug #1614103 reported by John Perkins
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Won't Fix
Low
Unassigned

Bug Description

In an OVO class, non-OVO class attributes (not 'version', 'db_model', 'fields', 'synthetic_fields', etc) should begin with an underscore so they cannot be confused with being part of the standardized OVO interface. QosPolicy has a class attribute called "binding_models" that is unrelated to OVO, so this should start with an underscore.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/356472

Changed in neutron:
assignee: nobody → John Perkins (john-d-perkins)
status: New → In Progress
Dariusz Smigiel (smigiel-dariusz)
Changed in neutron:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by John Perkins (<email address hidden>) on branch: master
Review: https://review.openstack.org/356472
Reason: Recently-merged changes cause several test failures in migration tests with this patch. It's a low priority, so abandoning for now in favor of higher priorities.

Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Bug closed due to lack of activity, please feel free to reopen if needed.

Changed in neutron:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.