Cannot filter OVSDB columns, only tables

[Omer Anson]

The current ovsdb connection class (neutron.agent.ovsdb.native.connection.Connection) allows filtering OVSDB tables, but not columns. Filtering columns may allow a performance gain when only specific columns in a table are accessed.

Specifically, this is a feature we are trying to use in Dragonflow[1], in class DFConnection and table columns ovsdb_monitor_table_filter_default.

[1] https://github.com/openstack/dragonflow/blob/master/dragonflow/db/drivers/ovsdb_vswitch_impl.py

[Omer Anson (omer-anson)]

The following patches attempt to answer this rfe:
https://review.openstack.org/#/c/323707
https://review.openstack.org/#/c/337418
https://review.openstack.org/#/c/329031

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/355943

[OpenStack Infra (hudson-openstack)]

Change abandoned by Omer Anson (<email address hidden>) on branch: master
Review: https://review.openstack.org/337418
Reason: See review comments for more info.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/323707
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=426408359951eadcbbcfe483622e0e95db8ea8da
Submitter: Jenkins
Branch: master

commit 426408359951eadcbbcfe483622e0e95db8ea8da
Author: Omer Anson <email address hidden>
Date: Wed Jun 1 10:18:49 2016 +0300

    Generate OVSDB schema helper in a separate method

    Move the generation of the schema helper in OVSDB connection to a
    different method

    In the OVSDB connection class, move the code retrieving the schema
    helper to a separate method. This will allow subclasses to override this
    method, and retrieve the schema helper in a different manner, or provide
    it to the Connection subclass in advance.

    This use-case came up in Dragonflow, where we wanted to retrieve
    specific columns within specific tables, and not the whole tables.

    Change-Id: I634841a2402e5d9bcbf1983a17eee2bb1a6299fb
    Related-Bug: 1612403

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/355943
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f7a2d4eb44bdba37a29417273f89228773c2f723
Submitter: Jenkins
Branch: master

commit f7a2d4eb44bdba37a29417273f89228773c2f723
Author: Omer Anson <email address hidden>
Date: Tue Aug 16 13:54:57 2016 +0300

    Add functional tests for OVSDB Connection

    Add functional tests for the class:
    neutron.agent.ovsdb.native.connection.Connection

    Change-Id: I92ab574f04efb5e09802fc1d97c2a5715b4ae48d
    Related-Bug: 1612403
    Co-Authored-By: Terry Wilson <email address hidden>

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/329031
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.