Migrating last HA router to legacy doesn't delete HA network

[John Schwarz]

As the title suggests, migrating a tenant's the last HA router from HA to legacy, doesn't cleanup the HA network.

[stack@js16 ~]$ neutron router-create x --ha=True
Created a new router:
+-------------------------+--------------------------------------+
| Field | Value |
+-------------------------+--------------------------------------+
| admin_state_up | True |
| availability_zone_hints | |
| availability_zones | |
| description | |
| distributed | False |
| external_gateway_info | |
| flavor_id | |
| ha | True |
| id | 2bafaae3-776b-4707-958b-f1df77d832fb |
| name | x |
| revision | 2 |
| routes | |
| status | ACTIVE |
| tenant_id | 20482218062b458589b9cffa3a1bb172 |
+-------------------------+--------------------------------------+
[stack@js16 ~]$ neutron router-update x --admin_state_up=False
Updated router: x
[stack@js16 ~]$ neutron router-update x --ha=False
Updated router: x
[stack@js16 ~]$ neutron router-delete x
Deleted router: x
[stack@js16 ~]$ neutron net-list
+--------------------------------------+----------------------------------------------------+----------------------------------------------------------+
| id | name | subnets |
+--------------------------------------+----------------------------------------------------+----------------------------------------------------------+
| 088ffed2-27a0-422e-b92c-c388e825cf8f | HA network tenant 20482218062b458589b9cffa3a1bb172 | 92ee2c83-8fdb-4767-90b3-bfb69fca452f 169.254.192.0/18 |
| e0e366ee-8a94-4753-8b9a-474bf692fb99 | public | e0933b88-7baf-47a9-84d8-7c98e140f747 172.24.4.0/24 |
| | | 400fa2e9-f373-4c7b-954c-f419d6dfba7b 2001:db8::/64 |
| fa13ed8e-dd44-4499-a3e8-531a25f26256 | private | 26f2f679-c255-4c36-93ac-7f6ec3e98ffe fd22:5205:4fcc::/64 |
| | | ed866867-1611-4919-bb3a-1ff0b4f1d36a 10.0.0.0/24 |
+--------------------------------------+----------------------------------------------------+----------------------------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/352068

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/352068
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f13f56f4032784fa3b2e1751c7c3a897877d2fe0
Submitter: Jenkins
Branch: master

commit f13f56f4032784fa3b2e1751c7c3a897877d2fe0
Author: John Schwarz <email address hidden>
Date: Sun Aug 7 11:23:59 2016 +0300

    Delete HA network if last HA router is migrated

    If an HA router is deleted and it's the last one a tenant has, the HA
    network is deleted as it's no longer needed. The same should occur when
    migrating the last HA router of a tenant from HA to Legacy.

    Closes-Bug: #1610645
    Change-Id: Ib27224c028bef98b78a5cea91e62ea98a2847008

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0b3 development milestone.