l3 code can leave orphaned ports

[Kevin Benton]

The L3 code creates ports and then RouterPort records for those ports in a separate transaction. If the server encounters an exception when creating the RouterPort records (e.g. lost connection to database, router was concurrently deleted, etc), the port will remain but will not have a RouterPort so it won't be able to be deleted.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/333809
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fbd3578d6494fa3f08d75686783f31454b1b42e5
Submitter: Jenkins
Branch: master

commit fbd3578d6494fa3f08d75686783f31454b1b42e5
Author: Kevin Benton <email address hidden>
Date: Wed Jun 22 18:23:19 2016 -0700

    Delete gw port on exceptions

    Clean up related core plugin ports on routers when there is a failure
    creating the record for the router port.

    The two partial bugs will be fixed after
    I476d3e03c8ee763cc4be6d679fe9f501eb3a19b5 has merged.

    Closes-Bug: #1600344
    Partial-Bug: #1535225
    Partial-Bug: #1535226
    Change-Id: I8dd832f35e20d1ee090ebab921f0deea533b6fc8

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/353263

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/353263
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=247128b6c3c03f3c096af9c27a97badbae11e666
Submitter: Jenkins
Branch: master

commit 247128b6c3c03f3c096af9c27a97badbae11e666
Author: Kevin Benton <email address hidden>
Date: Fri Aug 5 14:44:10 2016 -0700

    Fix duplicate routerport handling

    Change 6281fdd introduced a try: except to catch
    a DuplicateError introduced by it's new constraint.
    However, the try moved it outside of the context manager
    so it broke the port cleanup logic.

    This patch completely eliminates the catch for the
    duplicate entry since we retry those anyway which
    would let the regular check see the duplication.

    This also adds a test to prevent another regression of
    being moved outside of the context manager.

    Related-Bug: #1535551
    Related-Bug: #1600344

    Change-Id: I5f473fff4f8372852d563c79dac2991089eb0b77

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0b3 development milestone.