l2gw provider config prevents *aas provider config from being loaded

Bug #1599936 reported by YAMAMOTO Takashi on 2016-07-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devstack
Undecided
Unassigned
networking-l2gw
Undecided
Unassigned
neutron
High
YAMAMOTO Takashi

Bug Description

networking-l2gw devstack plugin stores its service_providers config in /etc/l2gw_plugin.ini
and add --config-file for it.
as a result, neutron-server is invoked like the following.

/usr/local/bin/neutron-server --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/midonet/midonet.ini --config-file /etc/neutron/l2gw_plugin.ini

it breaks *aas service providers because NeutronModule.service_providers finds
l2gw providers in cfg.CONF.service_providers.service_provider and thus doesn't look
at *aas service_providers config, which is in /etc/neutron/neutron_*aas.conf.

summary: - l2gw provider config prevents *aas provider config
+ l2gw provider config prevents *aas provider config from being loaded
YAMAMOTO Takashi (yamamoto) wrote :

devstack patch to use --config-dir: https://review.openstack.org/#/c/339369/

Fix proposed to branch: master
Review: https://review.openstack.org/342508

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress

We are deprecating the implicit loading behaviour: https://review.openstack.org/#/c/342048/

tags: added: deprecation

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/342508
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
milestone: none → newton-3
importance: Undecided → High

Reviewed: https://review.openstack.org/342048
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=49d1def76263326535fa19fa9940434cbb34a05a
Submitter: Jenkins
Branch: master

commit 49d1def76263326535fa19fa9940434cbb34a05a
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Jul 14 10:39:05 2016 +0200

    Deprecate implicit loading of service_providers from neutron_*.conf

    This feature is redundant, since it duplicates oslo.config functionality. If
    neutron-server needs to load the configuration option from multiple files, it
    should be achieved by passing multiple --config-dir/--config-file CLI
    arguments, not by relying on implicit loading for files with names matching the
    neutron_*.conf pattern.

    The plan is to stop implicit loading in Ocata.

    More details:
    http://lists.openstack.org/pipermail/openstack-dev/2016-May/096033.html

    Related-Bug: #1492069
    Related-Bug: #1599936
    Change-Id: I743e181532d285303c8d5c2a73f4fd674626b478

Changed in neutron:
milestone: newton-3 → newton-rc1

I don't think it's a bug in neutron. devstack should switch to loading service providers by explicitly passing --config-file to neutron_*aas.conf files. At which point l2gw will be able to pass their own file without breaking neutron service provider loading. The patches for the bug would span devstack and l2gw devstack plugin, but not neutron.

Changed in neutron:
status: In Progress → Invalid
Changed in neutron:
milestone: newton-rc1 → none

Reviewed: https://review.openstack.org/373830
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e80112ca627805b4ad85f26361be1e9618030dbc
Submitter: Jenkins
Branch: master

commit e80112ca627805b4ad85f26361be1e9618030dbc
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Sep 21 16:43:23 2016 +0900

    Fix a release note typo for implicit provider loading deprecation

    Don't repeat --config-dir option twice.

    Related-Bug: #1492069
    Related-Bug: #1599936
    Change-Id: I002b80ba8e5496c164d08357e4cce9e0b4abf5cf

Reviewed: https://review.openstack.org/374261
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2043cbd81f149dec1ef7e00c0e2de2f0aa863826
Submitter: Jenkins
Branch: stable/newton

commit 2043cbd81f149dec1ef7e00c0e2de2f0aa863826
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Sep 21 16:43:23 2016 +0900

    Fix a release note typo for implicit provider loading deprecation

    Don't repeat --config-dir option twice.

    Related-Bug: #1492069
    Related-Bug: #1599936
    Change-Id: I002b80ba8e5496c164d08357e4cce9e0b4abf5cf
    (cherry picked from commit e80112ca627805b4ad85f26361be1e9618030dbc)

tags: added: in-stable-newton
Changed in neutron:
status: Invalid → In Progress

Reviewed: https://review.openstack.org/342493
Committed: https://git.openstack.org/cgit/openstack-dev/devstack/commit/?id=eede9ddb1d0f0970672f02bcdfb33923603e65e7
Submitter: Jenkins
Branch: master

commit eede9ddb1d0f0970672f02bcdfb33923603e65e7
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Jul 15 10:27:53 2016 +0900

    Deprecate Q_PLUGIN_EXTRA_CONF_PATH

    This single global variable is no longer useful as we have multiple
    repositories and devstack plugins nowadays.

    Also, add a utility function, neutron_server_config_add, for devstack
    plugins to add an extra config file.

    Related-Bug: #1599936
    Change-Id: I90112823ef96ae2fba97d7b09b00bec8cb816d8d

tags: added: neutron-proactive-backport-potential

Reviewed: https://review.openstack.org/344045
Committed: https://git.openstack.org/cgit/openstack/networking-l2gw/commit/?id=3093340c74e4c473e551ffb22b270961466d0b7d
Submitter: Jenkins
Branch: master

commit 3093340c74e4c473e551ffb22b270961466d0b7d
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Jul 19 15:27:23 2016 +0900

    devstack: Stop using Q_PLUGIN_EXTRA_CONF_FILES

    Related-Bug: #1599936
    Depends-On: I90112823ef96ae2fba97d7b09b00bec8cb816d8d
    Change-Id: I060fd48c8a28ffa5243455b11cca8737392c86a4

Reviewed: https://review.openstack.org/342512
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=fb30a7a64fe4555a08a7dddf5fab1e8be8d58db0
Submitter: Jenkins
Branch: master

commit fb30a7a64fe4555a08a7dddf5fab1e8be8d58db0
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Jul 15 10:59:38 2016 +0900

    devstack: Add neutron server config explicitly

    Use neutron_server_config_add instead of Q_PLUGIN_EXTRA_CONF_FILES.

    Closes-Bug: #1643597
    Partial-Bug: #1599936
    Depends-On: I90112823ef96ae2fba97d7b09b00bec8cb816d8d
    Change-Id: If0bf812aac9f32011306face743218fe5f8b2aa8

Ricardo Noriega (rnoriega-b) wrote :

I don't think this is a bug since oslo config will gather and merge parameters such service_providers across multiple files. I'm setting this as "Invalid"

Changed in networking-l2gw:
status: New → Invalid
Changed in devstack:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers