relocate model definitions

Bug #1597913 reported by Manjeet Singh Bhatia
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Wishlist
Manjeet Singh Bhatia

Bug Description

with Oslo versioned object integration there might be lot of re factors required to avoid cyclic imports. which make it must for every resource to move model definition out of file which has Dbmixins in that. Instead of just creating a separate folder for defining model of each resource like this https://github.com/openstack/neutron/tree/master/neutron/db/extra_dhcp_opt and https://github.com/openstack/neutron/tree/master/neutron/db/allowed_address_pairs we can do it two ways either move all model definitions to single file or divide them based on categories (not more than 3 or 5) and move model definitions to respective ones.

Tags: db Edit Tag help
tags: added: rfe
Changed in neutron:
importance: Undecided → Wishlist
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Code refactoring proposals are not RFEs.

tags: removed: rfe
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

They are always welcome if they genuinely improve the maintainability and readability of the code.

Having said that I am not sure I understand what you're proposing, so perhaps you can just take your proposal in Gerrit and we take it from there.

Revision history for this message
Manjeet Singh Bhatia (manjeet-s-bhatia) wrote :

@Armando I meant while implementing ovo some
models definitions and mixins are in same file for example in dns extension neutron/db/dns_db

to avoid cyclic import object definitions need to move out so that oslo object can be imported and
replaced in mixins for sqlalchemy queries.

I have one example but this is gonna happen for all ovo patches which have their model definitions
and mixins in same file. so I was saying doing all at once will make ovo work little easy.

Revision history for this message
Victor Morales (electrocucaracha) wrote :

Just adding what Manjeet said. OVO team decided to create OVO and integrate them in a single patch. So, it's a common to see calls from mixin classess to model classes in the same file. As consequence we have to move those model classes to another location.

This could be a good opportunity to define a standard and place all the model class in a simple place without affecting the functionality but providing clean code.

Examples:

[1] https://review.openstack.org/#/c/306685/5/neutron/db/flavors_db.py@33

Changed in neutron:
assignee: nobody → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/348562

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/348757

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/349071

Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/351327

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/351438

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/351780

Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/351793

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Manjeet Singh Bhatia (<email address hidden>) on branch: master
Review: https://review.openstack.org/351327
Reason: It is no longer needed Henry suggested better solution in https://review.openstack.org/#/c/348562/

Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/351955

Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/352226

Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Sindhu Devale (sindhu-devale-3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: master
Review: https://review.openstack.org/351780
Reason: https://review.openstack.org/#/c/351438/ should cover the job.

Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/351438
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=34ec3536b2d1cab61222d2f2993e74988728a027
Submitter: Jenkins
Branch: master

commit 34ec3536b2d1cab61222d2f2993e74988728a027
Author: Manjeet Singh Bhatia <email address hidden>
Date: Fri Aug 5 00:24:26 2016 +0000

    Add devref for Relocating DB models

    This patch will add devref for relocating db models and
    it also explains why that change is required. It will also
    add a directory named models under tree neutron/db/.

    Change-Id: I160cecb76fb736307e5937122c84cdc0546207b6
    Related-Bug: #1597913

Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Sindhu Devale (sindhu-devale-3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/353643

Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Mohit Malik (mmalik4)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/353664

Changed in neutron:
assignee: Mohit Malik (mmalik4) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Artur Korzeniewski (artur-korzeniewski)
Changed in neutron:
assignee: Artur Korzeniewski (artur-korzeniewski) → Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/354393

Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/353664
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a92647300d0148d5d23f7c16631b192923702a1f
Submitter: Jenkins
Branch: master

commit a92647300d0148d5d23f7c16631b192923702a1f
Author: Victor Morales <email address hidden>
Date: Wed Aug 10 12:33:43 2016 -0500

    Relocate Security Group DB models

    This patch will separate security group db models from mixins for OVO
    implementation work.

    Change-Id: Ie38d3cc2efa5f580261f207748affb5840ba23c9
    Partial-Bug: #1597913

Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Mohit Malik (mmalik4)
assignee: Mohit Malik (mmalik4) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Mohit Malik (mmalik4)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/351793
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7c0f189309789ebcbd5c20c5a86835576ffb5db3
Submitter: Jenkins
Branch: master

commit 7c0f189309789ebcbd5c20c5a86835576ffb5db3
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Aug 5 17:13:44 2016 +0200

    models: move AllowedAddressPair model under neutron/db/models

    This patch moves the module into the canonical place. It does it in
    backwards compatible way, by leaving the model available under the old
    location, only emitting a deprecation warning on access from there. In
    the future, the old module will be completely cleaned up.

    This patch also makes head.py file that is used to import and register
    all models in the tree to import everything from under neutron.db.models
    without explicitly naming each module. In that way, we can avoid the
    need to import each new module with models as long as it's located in
    the designated place. The file is a well known abuser in terms of git
    conflicts, and it's better to avoid manual work.

    Change-Id: I084031e6b3c8d9113cc6ee6e3967f0e1edaee0b5
    Partial-Bug: #1597913

Changed in neutron:
assignee: Mohit Malik (mmalik4) → Tony Tan (tonytan4ever)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/355536

Changed in neutron:
assignee: Tony Tan (tonytan4ever) → asingh (aradhana1-singh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/355553

Changed in neutron:
assignee: asingh (aradhana1-singh) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/355594

Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Mohit Malik (mmalik4)
assignee: Mohit Malik (mmalik4) → Sindhu Devale (sindhu-devale-3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/355611

Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Sindhu Devale (sindhu-devale-3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/355643

Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Mohit Malik (mmalik4)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/355662

Changed in neutron:
assignee: Mohit Malik (mmalik4) → Nakul Dahiwade (nakul-dahiwade)
assignee: Nakul Dahiwade (nakul-dahiwade) → Shashank Kumar Shankar (shashank-kumar-shankar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/355719

Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Sindhu Devale (sindhu-devale-3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by tonytan4ever (<email address hidden>) on branch: master
Review: https://review.openstack.org/355553
Reason: Abandon due to duplication

Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Shashank Kumar Shankar (shashank-kumar-shankar)
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Nakul Dahiwade (nakul-dahiwade)
Changed in neutron:
assignee: Nakul Dahiwade (nakul-dahiwade) → Mohit Malik (mmalik4)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/356108

Changed in neutron:
assignee: Mohit Malik (mmalik4) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → asingh (aradhana1-singh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/356144

Changed in neutron:
assignee: asingh (aradhana1-singh) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Mohit Malik (mmalik4)
Changed in neutron:
assignee: Mohit Malik (mmalik4) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Mohit Malik (mmalik4)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/357016

Changed in neutron:
assignee: Mohit Malik (mmalik4) → QunyingRan (ran-qunying)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by QunyingRan (<email address hidden>) on branch: master
Review: https://review.openstack.org/357016
Reason: duplicated with https://review.openstack.org/#/c/334695/

Changed in neutron:
assignee: QunyingRan (ran-qunying) → Victor Morales (electrocucaracha)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/357054

Changed in neutron:
assignee: Victor Morales (electrocucaracha) → QunyingRan (ran-qunying)
Changed in neutron:
assignee: QunyingRan (ran-qunying) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Akihiro Motoki (amotoki)
Changed in neutron:
assignee: Akihiro Motoki (amotoki) → Nakul Dahiwade (nakul-dahiwade)
Changed in neutron:
assignee: Nakul Dahiwade (nakul-dahiwade) → Akihiro Motoki (amotoki)
Changed in neutron:
assignee: Akihiro Motoki (amotoki) → Mohit Malik (mmalik4)
Changed in neutron:
assignee: Mohit Malik (mmalik4) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Mohit Malik (mmalik4)
Changed in neutron:
assignee: Mohit Malik (mmalik4) → QunyingRan (ran-qunying)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/353643
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=72a722e69d4579e0df680735ab63305d522736aa
Submitter: Jenkins
Branch: master

commit 72a722e69d4579e0df680735ab63305d522736aa
Author: Mohit Malik <email address hidden>
Date: Wed Aug 10 09:57:33 2016 -0700

    Relocate AddressScope DB model

    Required to resolve cyclic import issue when integrating with Oslo
    Versioned Object for AddressScope

    Change-Id: If57e472c5827033f09a59d1f8d9359a3f241c17c
    Partial-Bug: #1597913

Changed in neutron:
assignee: QunyingRan (ran-qunying) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Akihiro Motoki (amotoki)
assignee: Akihiro Motoki (amotoki) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Mohit Malik (mmalik4)
Changed in neutron:
assignee: Mohit Malik (mmalik4) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Ankur (ankur-gupta-f)
Changed in neutron:
assignee: Ankur (ankur-gupta-f) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → QunyingRan (ran-qunying)
Changed in neutron:
assignee: QunyingRan (ran-qunying) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → QunyingRan (ran-qunying)
Changed in neutron:
assignee: QunyingRan (ran-qunying) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Nakul Dahiwade (nakul-dahiwade)
Changed in neutron:
assignee: Nakul Dahiwade (nakul-dahiwade) → QunyingRan (ran-qunying)
Changed in neutron:
assignee: QunyingRan (ran-qunying) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → QunyingRan (ran-qunying)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/359493

Changed in neutron:
assignee: QunyingRan (ran-qunying) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → QunyingRan (ran-qunying)
Changed in neutron:
assignee: QunyingRan (ran-qunying) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → QunyingRan (ran-qunying)
Changed in neutron:
assignee: QunyingRan (ran-qunying) → Sindhu Devale (sindhu-devale-3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/355643
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d7e6ce8a6ef31dc47db915d9e9186583f16daf6b
Submitter: Jenkins
Branch: master

commit d7e6ce8a6ef31dc47db915d9e9186583f16daf6b
Author: Mohit Malik <email address hidden>
Date: Mon Aug 15 14:06:24 2016 -0700

    Relocate GRE Db models

    Change-Id: I00afedc08c9ed7ab03ead9ef4bee94a80f50bb75
    Partial-Bug: #1597913

Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Sindhu Devale (sindhu-devale-3)
assignee: Sindhu Devale (sindhu-devale-3) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → QunyingRan (ran-qunying)
Changed in neutron:
assignee: QunyingRan (ran-qunying) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Shashank Kumar Shankar (shashank-kumar-shankar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by tonytan4ever (<email address hidden>) on branch: master
Review: https://review.openstack.org/359493
Reason: Abandon due to duplication

Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Brian Haley (brian-haley)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/361471

Changed in neutron:
assignee: Brian Haley (brian-haley) → Sindhu Devale (sindhu-devale-3)
assignee: Sindhu Devale (sindhu-devale-3) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → QunyingRan (ran-qunying)
Changed in neutron:
assignee: QunyingRan (ran-qunying) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → QunyingRan (ran-qunying)
Changed in neutron:
assignee: QunyingRan (ran-qunying) → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/354393
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a2e915977a26278b272020b5c0dbd17f3e793004
Submitter: Jenkins
Branch: master

commit a2e915977a26278b272020b5c0dbd17f3e793004
Author: sindhudevale <email address hidden>
Date: Thu Aug 11 20:53:48 2016 +0000

    Relocate Flat Allocation DB model

    Since there would be a circular import issue once we try to
    implement an object relying on the model, and adopt it in tree
    for database accessing code, this patch prepares the ground for
    this work by moving the model out of database accessing
    modules into neutron/db/models.

    Change-Id: I7876d28d35c5c4b9167520733e1a1b08dabc6951
    Partial-Bug: #1597913

Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Nakul Dahiwade (nakul-dahiwade)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/357054
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=16ba1213056030661128bcb82117e5c333b03630
Submitter: Jenkins
Branch: master

commit 16ba1213056030661128bcb82117e5c333b03630
Author: QunyingRan <email address hidden>
Date: Thu Aug 18 05:35:48 2016 -0400

    Relocate subnet_service_types db models

    This patch will relocate subnet_service_types db models and
    separate it from mixins for OVO implementation.

    Change-Id: Iec3db14a5049920cd370297ab6282b0b070156e7
    Partial-Bug: #1597913

Changed in neutron:
assignee: Nakul Dahiwade (nakul-dahiwade) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Anindita Das (anindita-das)
assignee: Anindita Das (anindita-das) → Sindhu Devale (sindhu-devale-3)
assignee: Sindhu Devale (sindhu-devale-3) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Victor Morales (electrocucaracha)
assignee: Victor Morales (electrocucaracha) → Sindhu Devale (sindhu-devale-3)
assignee: Sindhu Devale (sindhu-devale-3) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Sindhu Devale (sindhu-devale-3)
assignee: Sindhu Devale (sindhu-devale-3) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Sindhu Devale (sindhu-devale-3)
assignee: Sindhu Devale (sindhu-devale-3) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Nakul Dahiwade (nakul-dahiwade)
Changed in neutron:
assignee: Nakul Dahiwade (nakul-dahiwade) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Nakul Dahiwade (nakul-dahiwade)
Changed in neutron:
assignee: Nakul Dahiwade (nakul-dahiwade) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → John Woodburn (john-l-woodburn)
Changed in neutron:
assignee: John Woodburn (john-l-woodburn) → asingh (aradhana1-singh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/369550

Changed in neutron:
assignee: asingh (aradhana1-singh) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Shashank Kumar Shankar (shashank-kumar-shankar)
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Nakul Dahiwade (nakul-dahiwade)
assignee: Nakul Dahiwade (nakul-dahiwade) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Shashank Kumar Shankar (shashank-kumar-shankar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/355662
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=74229030b862250eb5625b5dd87476be5550e2b8
Submitter: Jenkins
Branch: master

commit 74229030b862250eb5625b5dd87476be5550e2b8
Author: Nakul Dahiwade <email address hidden>
Date: Mon Aug 15 22:01:50 2016 +0000

    Relocate PortBindingPort DB Model

    This patch moves PortBindingPort model under neutron/db/models for
    consistency.There are no plans to implement an OVO object for the model
    at this point in time. Actually, the model should probably eventually
    go away from Neutron tree since it's not used by reference plugin,
    and is just a remnant from the times when the neutron tree contained
    lots of plugins, some of which were using the model.

    Change-Id: I5728fea38816b7e500eaa836d5c5dadef51457f7
    Partial-Bug: #1597913

Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Sindhu Devale (sindhu-devale-3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/348562
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2b66c6a2ed77dcebcbe37ed6c6702c9190249b6e
Submitter: Jenkins
Branch: master

commit 2b66c6a2ed77dcebcbe37ed6c6702c9190249b6e
Author: Manjeet Singh Bhatia <email address hidden>
Date: Thu Jul 28 21:05:51 2016 +0000

    Relocate L3 DB Models

    As we have started oslo versioned objects implementations. There
    would be issue of cyclic import while implementation for objects
    which have db models definitions and mixins in same file. This patch
    will move routers models as discussed in [1].

    For example DNS models and some queries are in same file [2]. for object
    implementation I have separate models definitions and mixins where
    queries were being done [3].

    [1]. https://<email address hidden>/msg88910.html
    [2]. https://review.openstack.org/#/c/334695/15/neutron/db/dns_db.py
    [3]. https://review.openstack.org/#/c/334695/15/neutron/db/models/dns_models.py

    Change-Id: I9b9a44da5d28252be58cea1a920a64e18d8bbf32
    Partial-Bug: #1597913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/369550
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b078060189fc57541d854c00be6cee52b7166d72
Submitter: Jenkins
Branch: master

commit b078060189fc57541d854c00be6cee52b7166d72
Author: Anindita Das <email address hidden>
Date: Tue Sep 13 15:51:56 2016 +0000

    Relocate VxlanAllocation/VxlanEndpoints DB model

    This patch will relocate the VxlanAllocation and VxlanEndpoints db
    model from plugins/ml2/drivers to db/models/plugins/ml2 and separate
    it from mixins for OVO implementation.

    Change-Id: I14702ddcc5c32ba34b5f905a15cd816a69ef2b49
    Partial-Bug: #1597913

Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Victor Morales (electrocucaracha)
assignee: Victor Morales (electrocucaracha) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Anindita Das (anindita-das)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/378784

Changed in neutron:
assignee: Anindita Das (anindita-das) → Tony Tan (tonytan4ever)
assignee: Tony Tan (tonytan4ever) → Victor Morales (electrocucaracha)
assignee: Victor Morales (electrocucaracha) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Manjeet Singh Bhatia (manjeet-s-bhatia)
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Shashank Kumar Shankar (shashank-kumar-shankar)
Changed in neutron:
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Anindita Das (anindita-das)
Changed in neutron:
assignee: Anindita Das (anindita-das) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Ihar Hrachyshka (ihar-hrachyshka)
assignee: Ihar Hrachyshka (ihar-hrachyshka) → John Woodburn (john-l-woodburn)
Changed in neutron:
assignee: John Woodburn (john-l-woodburn) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/348757
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=820270fcacb1d16a342efee17a19ccd4669c1c30
Submitter: Jenkins
Branch: master

commit 820270fcacb1d16a342efee17a19ccd4669c1c30
Author: Manjeet Singh Bhatia <email address hidden>
Date: Fri Jul 29 07:05:06 2016 +0000

    Relocate Metering DB models

    This patch will separate metering db models from mixins
    for OVO implementation work.

    Change-Id: If1bdb64c36e1993d62269d390d3d18144b6c492d
    Partial-Bug: #1597913

Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → John Woodburn (john-l-woodburn)
Changed in neutron:
assignee: John Woodburn (john-l-woodburn) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/356144
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=558c0519e1efd20393fe0dfcd7fc1a47f0220061
Submitter: Jenkins
Branch: master

commit 558c0519e1efd20393fe0dfcd7fc1a47f0220061
Author: Anindita Das <email address hidden>
Date: Tue Aug 16 21:42:20 2016 +0000

    Relocate VlanAllocation DB model

    This patch will relocate the VlanAllocation db model from
    plugins/ml2/drivers to db/models and separate it from mixins for OVO
    implementation.

    Change-Id: Ib544b22c9e1acaf4025e8cdace694b2000a4da90
    Partial-Bug: #1597913

Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Sindhu Devale (sindhu-devale-3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/355719
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=930655cf57de523181b2d59bb4428b9f23991cce
Submitter: Jenkins
Branch: master

commit 930655cf57de523181b2d59bb4428b9f23991cce
Author: sindhudevale <email address hidden>
Date: Tue Aug 16 04:44:52 2016 +0000

    Relocate RouterL3AgentBinding DB model

    As there would be issue of cyclic imports while
    implementation of objects for l3agentbinding which has
    db models definition and mixins in same file, this patch will
    relocate l3agentbinding models.

    Change-Id: Idef2fe3e16b245da849e2d29c5578e5f5d081dc4
    Partial-Bug: #1597913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/355611
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0d81441af55ee34f70dc66efab1f875fd24ee043
Submitter: Jenkins
Branch: master

commit 0d81441af55ee34f70dc66efab1f875fd24ee043
Author: Shashank Kumar Shankar <email address hidden>
Date: Mon Aug 15 13:04:23 2016 -0500

    Relocate Provisioning Block DB Model

    As there would be issue of cyclic imports while implementation of
    objects for Provisioning Block which has db models definition in same
    file, this patch will move Provisioning Block model.

    Change-Id: I74402153267cac79a530c4f4f5bb7fd7df247e78
    Partial-Bug: #1597913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/355594
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e1a832dad8848d5ae41f27d0bf79cbdcc0b4ebaa
Submitter: Jenkins
Branch: master

commit e1a832dad8848d5ae41f27d0bf79cbdcc0b4ebaa
Author: sindhudevale <email address hidden>
Date: Mon Aug 15 18:34:38 2016 +0000

    Relocate Geneve DB models

    To avoid cyclic imports for OVO work.

    Change-Id: Iebd5a44d2195276e92111cb8964b90fc2955e2de
    Partial-Bug: #1597913

Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Victor Morales (electrocucaracha)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/378784
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=286af7c3f089bca679eaa18ea74c407dc37a0816
Submitter: Jenkins
Branch: master

commit 286af7c3f089bca679eaa18ea74c407dc37a0816
Author: Victor Morales <email address hidden>
Date: Wed Sep 28 10:16:53 2016 -0500

    Relocate ProviderResourceAssociation DB models

    This patch will separate ProviderResourceAssociation db models from
    mixins for Oslo-Versioned Objects implementation work.

    Change-Id: If650e0f6bdc41d175ba8be646cd043c875894ed7
    Partial-Bug: #1597913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/351955
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=276015788a2d7e331946b44eeb068089e0772a61
Submitter: Jenkins
Branch: master

commit 276015788a2d7e331946b44eeb068089e0772a61
Author: Manjeet Singh Bhatia <email address hidden>
Date: Fri Aug 5 23:28:53 2016 +0000

    Relocate external network db models

    This patch will relocate external network db models
    and separate it from mixins for OVO implementation.

    Change-Id: I83e2c7bbab3bd59cc9d2af71c66c0662c7724ecc
    Partial-Bug: #1597913

Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Victor Morales (electrocucaracha)
assignee: Victor Morales (electrocucaracha) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Shashank Kumar Shankar (shashank-kumar-shankar)
assignee: Shashank Kumar Shankar (shashank-kumar-shankar) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → asingh (aradhana1-singh)
Changed in neutron:
assignee: asingh (aradhana1-singh) → Tony Tan (tonytan4ever)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/380809

Changed in neutron:
assignee: Tony Tan (tonytan4ever) → John Schwarz (jschwarz)
Changed in neutron:
assignee: John Schwarz (jschwarz) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → asingh (aradhana1-singh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/356108
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=22b4f037dda09d124be4d5ac38eb9da871e88b13
Submitter: Jenkins
Branch: master

commit 22b4f037dda09d124be4d5ac38eb9da871e88b13
Author: Shashank Kumar Shankar <email address hidden>
Date: Tue Aug 16 13:37:52 2016 -0500

    Relocate Router Extra Attributes DB Model

    As there would be issue of cyclic imports while the implementation
    of Oslo-versioned Objects for Router Extra Attributes which has DB
    models definition in same file, this patch will move Router Extra
    Attributes model.

    Change-Id: I8c90e35ef08ef74fb5309707673796e587a7289e
    Partial-Bug: #1597913

Changed in neutron:
assignee: asingh (aradhana1-singh) → Sindhu Devale (sindhu-devale-3)
Changed in neutron:
assignee: Sindhu Devale (sindhu-devale-3) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/380809
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f327aa67500187c068bef3296b8de829c98de8ab
Submitter: Jenkins
Branch: master

commit f327aa67500187c068bef3296b8de829c98de8ab
Author: John Schwarz <email address hidden>
Date: Sun Oct 2 09:45:37 2016 +0300

    Remove deprecation warning for l3_agent_scheduler

    Change Idef2fe3e16b245da849e2d29c5578e5f5d081dc4 relocated the
    RouterL3AgentBinding model, but the last rebase didn't change all the
    references of this model - there was one left.

    Change-Id: Id48d48413ecc2f55fc889b8d19a6760c16434d96
    Partial-Bug: #1597913

Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Victor Morales (electrocucaracha)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/355059
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f9b1f0906c7eee7225549d956f51f93a8465413f
Submitter: Jenkins
Branch: master

commit f9b1f0906c7eee7225549d956f51f93a8465413f
Author: sindhudevale <email address hidden>
Date: Fri Aug 12 20:07:50 2016 +0000

    Relocate L3HARouter DB model

    As there would be issue of circular imports while
    implementation of Oslo-Versioned Objects for L3HArouter which has
    db models definition and mixins in same file, this patch will
    move L3HArouter models into a separate module.

    Change-Id: I44e638fb4c19a2bdd513b67baeb7e6a2acc72d2f
    Partial-Bug: #1597913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/361471
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cf6d700390ed945ffde1fd344d69b496c3954cbc
Submitter: Jenkins
Branch: master

commit cf6d700390ed945ffde1fd344d69b496c3954cbc
Author: Aradhana Singh <email address hidden>
Date: Fri Aug 26 16:01:49 2016 -0500

    Relocate SegmentHostMapping DB model

    This patch relocates SegmentHostMapping db model to neutron/db/models.

    Partial-Bug: #1597913

    Change-Id: I630e5c42f9ab781ba6565cdf0f780bf78c2b5dc7

Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/355536
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b6a296edf6f6ae1c5b07ccafd98c000ebf1bf997
Submitter: Jenkins
Branch: master

commit b6a296edf6f6ae1c5b07ccafd98c000ebf1bf997
Author: Aradhana Singh <email address hidden>
Date: Thu Sep 1 20:23:22 2016 +0000

    Relocate Tag DB model

    This patch relocates Tag db model from neutron/db to neutron/db/models

    Change-Id: Ibb9325f30af85300afe62bb5415388271cf13833
    Partial-Bug: #1597913

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/353541
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=509bc4c2abc67f4deaa947bec3735a5236a61516
Submitter: Jenkins
Branch: master

commit 509bc4c2abc67f4deaa947bec3735a5236a61516
Author: tonytan4ever <email address hidden>
Date: Sun Aug 14 22:42:16 2016 -0400

    Relocate dvr model

    As there would be issue of cyclic imports while implementation of
    Oslo-Versioned Objects for DVR which has db models definition and
    mixins in same file, this patch will relocate DVR models.

    Change-Id: I4005570c7507ae9c28fd2910b368e4fdf5e603b0
    Co-Authored-By: Victor Morales <email address hidden>
    Partial-Bug: #1597913

Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Victor Morales (electrocucaracha)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/349071
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fc93f7fcdba34fdb4f41c60e6e532262b8dbcebb
Submitter: Jenkins
Branch: master

commit fc93f7fcdba34fdb4f41c60e6e532262b8dbcebb
Author: Victor Morales <email address hidden>
Date: Fri Jul 29 15:38:06 2016 -0500

    Relocate Flavor and ServiceProfile DB models

    This patch will separate flavor and service profile db models from
    mixins for Oslo-Versioned Objects implementation work.

    Change-Id: Ia35d24c075dc716e44fbf8a9b6a2ebb0297e7aa9
    Partial-Bug: #1597913

Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Victor Morales (electrocucaracha)
Changed in neutron:
assignee: Victor Morales (electrocucaracha) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/352226
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=72ddd2338b094d32b0393ca2b510dd8ffa5ae48e
Submitter: Jenkins
Branch: master

commit 72ddd2338b094d32b0393ca2b510dd8ffa5ae48e
Author: sindhu devale <email address hidden>
Date: Mon Aug 8 05:29:12 2016 +0000

    Relocate Segment DB Models

    As there would be issue of cyclic imports while implementation of
    objects for segments which has db models definition and mixins in same
    file, this patch will relocate segment models.

    Change-Id: I6f5aea69a0f7f1647bb06c86f1fac9367717033c
    Partial-Bug: #1597913
    Co-Authored-By: Victor Morales <email address hidden>

Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → Tony Tan (tonytan4ever)
Changed in neutron:
assignee: Tony Tan (tonytan4ever) → Nakul Dahiwade (nakul-dahiwade)
Changed in neutron:
assignee: Nakul Dahiwade (nakul-dahiwade) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/334695
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ead39faa377cd30a0184920de6cac89793864e1d
Submitter: Jenkins
Branch: master

commit ead39faa377cd30a0184920de6cac89793864e1d
Author: Manjeet Singh Bhatia <email address hidden>
Date: Mon Jun 27 22:33:31 2016 +0000

    Relocate DNS db models

    This patch relocate db models for dns.

    Partial-Bug: #1597913

    Change-Id: I6d1b43d8c5c8d6f8b80730a16eedac5e59cbed44

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/330870
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e669e7b96b48bfdb95f78dd3ff3f9bba862fb376
Submitter: Jenkins
Branch: master

commit e669e7b96b48bfdb95f78dd3ff3f9bba862fb376
Author: tonytan4ever <email address hidden>
Date: Tue Oct 4 14:18:42 2016 -0400

    Relocate Agent DB model

    This patch set is for breaking the circular dependency between
    Agent/AgentVersionedObject.
    See:https://review.openstack.org/#/c/297887/ for details.

    Change-Id: I7be4ce2513e49e6da46a7bdffb8538613f0be7c7
    Partial-Bug: #1597913
    Co-Authored-By: Victor Morales <email address hidden>
    Co-Authored-By: Sindhu Devale <email address hidden>

Changed in neutron:
status: In Progress → Fix Released
status: Fix Released → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/385950

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/385950
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=013a48f49b4141e4c865aeffc85a9e29a9d25c71
Submitter: Jenkins
Branch: master

commit 013a48f49b4141e4c865aeffc85a9e29a9d25c71
Author: John Schwarz <email address hidden>
Date: Thu Oct 13 15:12:28 2016 +0300

    Remove deprecation warnings for agents_db

    Change I7be4ce2513e49e6da46a7bdffb8538613f0be7c7 relocated the Agent
    model (and a few other functions), but some references to old
    functions/model still remain. These cause a considerable amount of
    warnings when running unit tests and the code itself.

    Change-Id: Id026cae75bfa56b1023f8a1c4e5db750cf0bff5f
    Partial-Bug: #1597913

tags: added: db
Changed in neutron:
milestone: none → ocata-1
status: Fix Committed → Fix Released
summary: - refactor model definitions
+ relocate model definitions
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers