pep8 job runs a single check only

Bug #1594756 reported by Jakub Libosvar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Jakub Libosvar

Bug Description

Due to https://github.com/PyCQA/pycodestyle/issues/390 , we now run only check that makes sure we use unittest2 instead of unittest.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/332059

Changed in neutron:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Jakub Libosvar (libosvar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/332059
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=766abb752aaf3766eff69654b3d2654dddcd81cd
Submitter: Jenkins
Branch: master

commit 766abb752aaf3766eff69654b3d2654dddcd81cd
Author: Jakub Libosvar <email address hidden>
Date: Tue Jun 21 10:14:45 2016 +0000

    Make pep8 job great again

    There is a bug in pep8, when 'select' used, it omits all default checks
    and runs only those specified by 'select'. We got hit by this issue
    since I2d26534230ffe5d01aa0aab6ec902f81cfba774d was merged which lead to
    almost no static checks in pep8 job.

    Also note that off_by_default decorator has no effect for now because
    factory in hacking is triggered after ignored checks are collected.
    There will be a follow-up patch for that in order to make pep8 doing
    its job quickly.

    [1] https://github.com/PyCQA/pycodestyle/issues/390

    Related-Bug: 1594756
    Change-Id: I8e27f40908e1bb4307cc7c893169a9d99f3433c4

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334986

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/334986
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3ff5b704a7a52fe46f24061d266a30ee44bdeaef
Submitter: Jenkins
Branch: master

commit 3ff5b704a7a52fe46f24061d266a30ee44bdeaef
Author: Jakub Libosvar <email address hidden>
Date: Tue Jun 28 07:26:26 2016 -0400

    pep8: Register checks with their code

    pep8 searches for check codes in their docstrings [1]. This allows us to
    either ignore or select particular checks by their codes.

    e.g. flake8 --select=N333

    [1] https://github.com/PyCQA/pycodestyle/blob/4438622d0b62df53a1999301d1bdc9fa119ae763/pycodestyle.py#L110

    Change-Id: I4644ab087abc441beed52a170df8b5279fed76a4
    Closes-bug: 1594756

Changed in neutron:
status: In Progress → Fix Released
tags: added: neutron-proactive-backport-potential
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b2

This issue was fixed in the openstack/neutron 9.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/379781

tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/379781
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1cd05858846698fc77c10a6131c3900f8e974e70
Submitter: Jenkins
Branch: master

commit 1cd05858846698fc77c10a6131c3900f8e974e70
Author: Dariusz Smigiel <email address hidden>
Date: Thu Sep 29 19:28:38 2016 +0000

    Removed deprecated checks

    Change I4644ab087abc441beed52a170df8b5279fed76a4 changed functions
    check_asserttrue and check_assertfalse into check_asserttruefalse.
    Please use latter.

    Change-Id: Ifb38143a0045dd29c81b3507554196ab9b19c787
    Related-Bug: #1594756

tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.