[RFE] No notification on floating ip status change

[Steve McLellan]

Tested on neutron/master in devstack.

When I associate or disassociate a floating IP I get a notification indicating the new fixed IP and port association, but the status still indicates the current value (so for associate, the notification contains "fixed_ip_address":"a.b.c.d", "status": "DOWN") because there's a short latency time before the FIP is marked as ACTIVE.

I see the status change after a very short period after in the q-svc log:

    New status for floating IP 8470e622-0f3b-419f-ac21-deed658d3260: ACTIVE

There's no notification emitted representing this state change, however. The same is true on disassociate; the port and fixed IP are cleared but the status is indicated ACTIVE and there's no notification marking it DOWN.

E.g.
$ neutron floatingip-create 0e97853d-3ac0-4c08-a8b3-f6bfa443dd24

{"event_type": "floatingip.create.end", "payload": {"floatingip": {"router_id": null, "status": "DOWN", "description": "", "tenant_id": "c1b853bf78bc43c69daa8d42cb9fb07f", "floating_network_id": "0e97853d-3ac0-4c08-a8b3-f6bfa443dd24", "fixed_ip_address": null, "floating_ip_address": "172.25.0.11", "port_id": null, "id": "6442165e-4caa-437c-9377-196f4db638f9"}}, "publisher_id": "network.devstack", "ctxt": {...}, "metadata": {"timestamp": "2016-06-17 16:44:20.600943", "message_id": "547b0f34-1bc0-4fbc-8e58-a0c2d2dc1751"}}

$ neutron floatingip-associate 6442165e-4caa-437c-9377-196f4db638f9 8068c884-1ab4-42d9-97d0-f65848fca2b0

{"event_type": "floatingip.update.end", "payload": {"floatingip": {"router_id": "390ab366-0eee-46e9-a07f-f49cf0b31652", "status": "DOWN", "description": "", "tenant_id": "c1b853bf78bc43c69daa8d42cb9fb07f", "floating_network_id": "0e97853d-3ac0-4c08-a8b3-f6bfa443dd24", "fixed_ip_address": "172.40.0.4", "floating_ip_address": "172.25.0.11", "port_id": "8068c884-1ab4-42d9-97d0-f65848fca2b0", "id": "6442165e-4caa-437c-9377-196f4db638f9"}}, "publisher_id": "network.devstack", "ctxt": {...}, "metadata": {"timestamp": "2016-06-17 16:44:50.149631", "message_id": "f6f7ec1f-6363-49b0-b10f-84fd81e0a506"}}

[Boden R (boden)]

I assume this one was discussed in the neutron meeting and decided it should be an RFE??

Adding notifications for FIP seemed pretty straight forward to me, and hence I was assuming it could move straight to tech discussions via patch reviews.

[Akihiro Motoki (amotoki)]

At now, notification events are only sent when API operations are made.

This request is to send notification events for resource changes from other reasons. It sounds reasonable, but it is better to generalize the change to all other events (for example, port status).

Technically, I think it can be achieved by the event registry.

[Armando Migliaccio (armando-migliaccio)]

Btw I encountered something similar with DHCP notifications. I ended up solving this with [1], however in this case when the agent comes back and update the floating IP status, only the DB field is updated without putting a message on the notification queue. As Akihiro suggested this is achievable via a registry callback notification and the nuances of this can be dealt with code review.

[1] https://review.openstack.org/#/c/329006/

[Armando Migliaccio (armando-migliaccio)]

@Boden: go for it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/345654

[Armando Migliaccio (armando-migliaccio)]

It seems the patch that actually fixes the bug is not being posted yet.

[Boden R (boden)]

Armando RE comment #6:

Why is [1] not a fix for this (albeit stalled waiting on a dependent patch)?

[1] https://review.openstack.org/#/c/345654/

[Armando Migliaccio (armando-migliaccio)]

I didn't say that, I said it is not complete.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/345654
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/345654
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Bug closed due to lack of activity, please feel free to reopen if needed.