TestDesignateClient.test_secure_client fails with AssertionError: Expected call: mock(verify='...')

[Ihar Hrachyshka]

The test sometimes fails in gate:

http://logs.openstack.org/30/271830/8/check/gate-neutron-python27/4b77bb6/testr_results.html.gz

ft507.2: neutron.tests.unit.plugins.ml2.extensions.test_dns_integration.TestDesignateClient.test_secure_client_StringException: Traceback (most recent call last):
  File "neutron/tests/unit/plugins/ml2/extensions/test_dns_integration.py", line 558, in test_secure_client
    driver.session.Session.assert_called_with(verify=self.TEST_CA_CERT)
  File "/home/jenkins/workspace/gate-neutron-python27/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 925, in assert_called_with
    raise AssertionError('Expected call: %s\nNot called' % (expected,))
AssertionError: Expected call: mock(verify='d7302899d10b4e8381f2345b966fd299')
Not called

Logstash: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22in%20test_secure_client%5C%22

[Dariusz Smigiel (smigiel-dariusz)]

It seems to happening just for py27

[Ihar Hrachyshka (ihar-hrachyshka)]

Sigh, seems no one actually cared since I reported it. I guess I will need to fix it myself.

[Ihar Hrachyshka (ihar-hrachyshka)]

Reproduction is as simple as: python -m testtools.run neutron.tests.unit.plugins.ml2.extensions.test_dns_integration.TestDesignateClient

[Ihar Hrachyshka (ihar-hrachyshka)]

Fix: https://review.openstack.org/#/c/331541/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/331541
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3703b31eea06d5055a7fc63cec7a24b2aaa1c563
Submitter: Jenkins
Branch: master

commit 3703b31eea06d5055a7fc63cec7a24b2aaa1c563
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Jun 20 09:38:13 2016 +0200

    tests: clean up designate client session mock on test exit

    This test was modifying the driver session method without making an
    effort to restore the original value after the test case completion.
    This resulted in two consequent tests that relied on the method that
    were triggered in the same test thread, to trigger a failure for one of
    them.

    Changed the setup logic for the test class to use mock.patch(..).start()
    instead.

    Closes-Bug: #1593647
    Change-Id: I08be90691b5417025c40c5a18308d820dc7a43d2

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/331662

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/331662
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=97088cf1a63d5d1a28ffaf7fa338ad1fb1b84342
Submitter: Jenkins
Branch: stable/mitaka

commit 97088cf1a63d5d1a28ffaf7fa338ad1fb1b84342
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Jun 20 09:38:13 2016 +0200

    tests: clean up designate client session mock on test exit

    This test was modifying the driver session method without making an
    effort to restore the original value after the test case completion.
    This resulted in two consequent tests that relied on the method that
    were triggered in the same test thread, to trigger a failure for one of
    them.

    Changed the setup logic for the test class to use mock.patch(..).start()
    instead.

    Closes-Bug: #1593647
    Change-Id: I08be90691b5417025c40c5a18308d820dc7a43d2
    (cherry picked from commit 3703b31eea06d5055a7fc63cec7a24b2aaa1c563)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 9.0.0.0b2 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 8.2.0 release.