Service plugin class' get_plugin_type should be a classmethod
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
networking-midonet |
Fix Released
|
Low
|
YAMAMOTO Takashi | ||
neutron |
Fix Released
|
Undecided
|
Brandon Logan | ||
tap-as-a-service |
Fix Released
|
Undecided
|
YAMAMOTO Takashi |
Bug Description
There isn't any reason to have it as an instance method as its only returning a constant.
$ git grep 'def get_plugin_type('
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
neutron/
description: | updated |
summary: |
- Segment Extension get_plugin method should be a classmethod + Service plugin base class's get_plugin_type should be a classmethod |
summary: |
- Service plugin base class's get_plugin_type should be a classmethod + Service plugin class's get_plugin_type should be a classmethod |
summary: |
- Service plugin class's get_plugin_type should be a classmethod + Service plugin class' get_plugin_type should be a classmethod |
Changed in networking-midonet: | |
milestone: | 2.0.0 → 3.0.0 |
tags: | added: neutron-proactive-backport-potential |
tags: | removed: neutron-proactive-backport-potential |
Fix proposed to branch: master /review. openstack. org/326716
Review: https:/