test_add_list_remove_router_on_l3_agent may fail on envs where there is >= two L3 agents and DVR enabled

[Yaroslav Lobankov]

Environment:
OpenStack (Mitaka release), where there is more than one L3 agent and DVR enabled.

When DVR is disabled, the resource_setup method just creates a router. When DVR is enabled, the resource_setup method creates a router and then adds an internal network interface to the created router. After we added the internal network interface to the router, the router is automatically hosted by some L3 agent. Then the test starts and tries to add the router to one of L3 agents and fails because the router is already hosted by another L3 agent.

tempest.lib.exceptions.Conflict: An object with that identifier already exists
Details: {u'message': u'The router 8569d347-6db4-4e12-b033-60a867ba680f has been already hosted by the L3 Agent 6250d031-d455-4afe-b993-5a7719815746.', u'type': u'RouterHostedByL3Agent', u'detail': u''}

The full log can be found here http://paste.openstack.org/show/508686/

A DVR router can be bound to some L3 agent without adding an internal network interface to the created router since the Mitaka release.

Liberty - http://paste.openstack.org/show/574456/
Mitaka - http://paste.openstack.org/show/574455/

In order to fix the test, we need to remove the code block where we add the internal network interface to the router, but it will not work with the Liberty release. So we can skip the test until Liberty is EOL and after that fix the test.

[Oleksiy Butenko (obutenko)]

https://review.openstack.org/#/c/322118/

[Armando Migliaccio (armando-migliaccio)]

We have the same test in the neutron repo. Assaf suggested at one point [1,2] that this is a test that should live in the neutron repo only. Whether or not we complete the effort, we want to make sure we track this issue in both projects.

[1] https://etherpad.openstack.org/p/neutron-tempest-defork
[2] https://bugs.launchpad.net/neutron/+bug/1552960

[Yaroslav Lobankov (ylobankov)]

Actually, It was fixed by https://review.openstack.org/#/c/370236/ a long time ago. We added a flag that changes test behavior depending on the flag value.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322118
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=61d42c7615e08422cbd8ca68c64f2f5ff14916a2
Submitter: Jenkins
Branch: master

commit 61d42c7615e08422cbd8ca68c64f2f5ff14916a2
Author: Yaroslav Lobankov <email address hidden>
Date: Fri May 27 14:34:08 2016 +0300

    Set default value of 'dvr_extra_resources' option to False

    The default value of the option was set to True to support Liberty
    which is not supported anymore. So let's set the default value of
    the option to False.

    Related-Bug: #1590049

    Change-Id: Idb39e7d60e01bf4a0abf42b1003f0b60fe56cded

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/421155
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=08d29e3c90093c508fb8ebc511ca5caca1716379
Submitter: Jenkins
Branch: master

commit 08d29e3c90093c508fb8ebc511ca5caca1716379
Author: Genadi Chereshnya <email address hidden>
Date: Tue Jan 17 11:06:42 2017 +0200

    Tempest: Fixing L3 agent hosting router for DVR setup

    The tests for L3 agent hosting routers were failing in DVR setup
    because the code was trying to add router to l3 agent when it was
    already there.

    Closes-bug: #1590049

    Change-Id: I0087ad6f6df662579d557ab790de64e04ff22943

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/454594

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/454594
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e79ae4e679c21b4ee1ca1d1c8a072593361deb7c
Submitter: Jenkins
Branch: stable/ocata

commit e79ae4e679c21b4ee1ca1d1c8a072593361deb7c
Author: Genadi Chereshnya <email address hidden>
Date: Tue Jan 17 11:06:42 2017 +0200

    Tempest: Fixing L3 agent hosting router for DVR setup

    The tests for L3 agent hosting routers were failing in DVR setup
    because the code was trying to add router to l3 agent when it was
    already there.

    Closes-bug: #1590049

    Change-Id: I0087ad6f6df662579d557ab790de64e04ff22943
    (cherry picked from commit 08d29e3c90093c508fb8ebc511ca5caca1716379)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.2 release.