DVR: regression with router rescheduling

[Oleg Bondarev]

L3 agent may not fully process dvr router being rescheduled to it which leads to loss of external connectivity.
The reason is that with commit 9dc70ed77e055677a4bd3257a0e9e24239ed4cce dvr edge router now creates snat_namespace object in constructor while some logic in the module still checks for existence of this object: like external_gateway_updated() will not fully process router if snat_namespace object exists.

The proposal is to revert commit 9dc70ed77e055677a4bd3257a0e9e24239ed4cce and the make another attempt to fix bug 1557909.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326574

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/326576

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/326577

[Swaminathan Vasudevan (swaminathan-vasudevan)]

can you elaborate on the issue, I don't get the point, external_gateway_updated() will not fully process router.

Can you provide the steps to reproduce this problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326729

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/327509

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326574
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e4b82f7e645654ad43b378bd5f243e97a16112e6
Submitter: Jenkins
Branch: master

commit e4b82f7e645654ad43b378bd5f243e97a16112e6
Author: Oleg Bondarev <email address hidden>
Date: Tue Jun 7 15:26:23 2016 +0000

    Revert "DVR: Clear SNAT namespace when agent restarts after router move"

    This reverts commit 9dc70ed77e055677a4bd3257a0e9e24239ed4cce.

    Change-Id: I85a8051d56c535a4de4c70b3624eb7ccefa9e656
    Closes-Bug: #1590041

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326576
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=957e7580a4c4912ed328933bfbeb19328d7cd5f5
Submitter: Jenkins
Branch: stable/liberty

commit 957e7580a4c4912ed328933bfbeb19328d7cd5f5
Author: Oleg Bondarev <email address hidden>
Date: Tue Jun 7 15:27:45 2016 +0000

    Revert "DVR: Clear SNAT namespace when agent restarts after router move"

    This reverts commit d29e2f77d3933ea0279bf1863a31baf3a73a86e7.

    Change-Id: I7521538c6f62fff987e19b16a2e33a7b7a7202e9
    Closes-Bug: #1590041

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326577
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1eccf150cd016e450e2705b828ef7de61efb22bc
Submitter: Jenkins
Branch: stable/mitaka

commit 1eccf150cd016e450e2705b828ef7de61efb22bc
Author: Oleg Bondarev <email address hidden>
Date: Tue Jun 7 15:28:04 2016 +0000

    Revert "DVR: Clear SNAT namespace when agent restarts after router move"

    This reverts commit b9103329855481b1415a07e6b31206ba35dabc7d.

    Change-Id: I9c0c2289e09ff2ac62dd6417d2f8fcf323ef1340
    Closes-Bug: #1590041

[OpenStack Infra (hudson-openstack)]

Change abandoned by Swaminathan Vasudevan (<email address hidden>) on branch: master
Review: https://review.openstack.org/327509
Reason: Will go ahead with the previous option.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/neutron 7.1.1 release.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/neutron 8.1.2 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 9.0.0.0b2 development milestone.