AttributeError: type object 'BaseNetworkTest' has no attribute '_try_delete_resource'

Bug #1589521 reported by Ihar Hrachyshka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Critical
Ihar Hrachyshka
tap-as-a-service
Fix Released
Undecided
YAMAMOTO Takashi

Bug Description

Neutron API job broken by a change in tempest: https://review.openstack.org/#/c/277907/

...and fwaas tempest plugin using internal symbols from tempest.

Logs: http://logs.openstack.org/41/325141/3/gate/gate-neutron-dsvm-api/281611d/console.html#_2016-06-06_12_27_35_286

2016-06-06 12:27:35.198 | Failed to import test module: neutron_fwaas.tests.tempest_plugin.tests.api.test_fwaas_extensions
2016-06-06 12:27:35.237 | Traceback (most recent call last):
2016-06-06 12:27:35.242 | File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 456, iNon-zero exit code (2) from test listing.
2016-06-06 12:27:35.242 | nerror: testr failed (3)
2016-06-06 12:27:35.243 | _find_test_path
2016-06-06 12:27:35.245 | module = self._get_module_from_name(name)
2016-06-06 12:27:35.280 | File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
2016-06-06 12:27:35.281 | __import__(name)
2016-06-06 12:27:35.285 | File "/opt/stack/new/neutron-fwaas/neutron_fwaas/tests/tempest_plugin/tests/api/test_fwaas_extensions.py", line 23, in <module>
2016-06-06 12:27:35.286 | from neutron_fwaas.tests.tempest_plugin.tests.api import base
2016-06-06 12:27:35.286 | File "/opt/stack/new/neutron-fwaas/neutron_fwaas/tests/tempest_plugin/tests/api/base.py", line 21, in <module>
2016-06-06 12:27:35.286 | class BaseFWaaSTest(fwaas_client.FWaaSClientMixin, base.BaseNetworkTest):
2016-06-06 12:27:35.286 | File "/opt/stack/new/neutron-fwaas/neutron_fwaas/tests/tempest_plugin/tests/api/base.py", line 22, in BaseFWaaSTest
2016-06-06 12:27:35.286 | _delete_wrapper = base.BaseNetworkTest._try_delete_resource
2016-06-06 12:27:35.286 | AttributeError: type object 'BaseNetworkTest' has no attribute '_try_delete_resource'
2016-06-06 12:27:35.286 |
2016-06-06 12:27:35.286 | Failed to import test module: neutron_fwaas.tests.tempest_plugin.tests.scenario.test_fwaas
2016-06-06 12:27:35.286 | Traceback (most recent call last):
2016-06-06 12:27:35.287 | File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 456, in _find_test_path
2016-06-06 12:27:35.287 | module = self._get_module_from_name(name)
2016-06-06 12:27:35.287 | File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
2016-06-06 12:27:35.287 | __import__(name)
2016-06-06 12:27:35.287 | File "/opt/stack/new/neutron-fwaas/neutron_fwaas/tests/tempest_plugin/tests/scenario/test_fwaas.py", line 21, in <module>
2016-06-06 12:27:35.287 | from neutron_fwaas.tests.tempest_plugin.tests.scenario import base
2016-06-06 12:27:35.287 | File "/opt/stack/new/neutron-fwaas/neutron_fwaas/tests/tempest_plugin/tests/scenario/base.py", line 27, in <module>
2016-06-06 12:27:35.287 | manager.NetworkScenarioTest):
2016-06-06 12:27:35.287 | File "/opt/stack/new/neutron-fwaas/neutron_fwaas/tests/tempest_plugin/tests/scenario/base.py", line 28, in FWaaSScenarioTest
2016-06-06 12:27:35.287 | _delete_wrapper = manager.NetworkScenarioTest.delete_wrapper
2016-06-06 12:27:35.287 | AttributeError: type object 'NetworkScenarioTest' has no attribute 'delete_wrapper'
2016-06-06 12:27:35.287 | The test run didn't actually run any tests

tags: added: fwaas gate-failure
Changed in neutron:
importance: Undecided → Critical
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/325940

Changed in neutron:
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)
status: Confirmed → In Progress
Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Armando Migliaccio (armando-migliaccio)
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

The appropriate would be not to install fwaas in the api job configuration

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/326107

Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :

an alternative fix, which looks better to me.
https://review.openstack.org/#/c/326150/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-fwaas (stable/mitaka)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/326107
Reason: Superseded by https://review.openstack.org/#/c/326150/

Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :
Changed in tap-as-a-service:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-fwaas (master)

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: master
Review: https://review.openstack.org/325940

Changed in neutron:
assignee: Armando Migliaccio (armando-migliaccio) → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/326150
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=a59df892d3f90f97c967a46b6c18e595d60a9b85
Submitter: Jenkins
Branch: master

commit a59df892d3f90f97c967a46b6c18e595d60a9b85
Author: Ken'ichi Ohmichi <email address hidden>
Date: Mon Jun 6 14:44:51 2016 -0700

    Use call_and_ignore_notfound_exc directly

    This patch makes fwaas_client use call_and_ignore_notfound_exc
    directly because the client only uses it.

    Closes-Bug: #1589521
    Change-Id: I3abd9049560ee507b3610ab482c697a239f13a3b

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/327068

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (stable/mitaka)

Reviewed: https://review.openstack.org/327068
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=b10351736ed3cfd7d926b4f4cf24c19812ea3c37
Submitter: Jenkins
Branch: stable/mitaka

commit b10351736ed3cfd7d926b4f4cf24c19812ea3c37
Author: Ken'ichi Ohmichi <email address hidden>
Date: Mon Jun 6 14:44:51 2016 -0700

    Use call_and_ignore_notfound_exc directly

    This patch makes fwaas_client use call_and_ignore_notfound_exc
    directly because the client only uses it.

    Closes-Bug: #1589521
    Change-Id: I3abd9049560ee507b3610ab482c697a239f13a3b
    Cherry-pick from I3abd9049560ee507b3610ab482c697a239f13a3b

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tap-as-a-service (master)

Reviewed: https://review.openstack.org/326231
Committed: https://git.openstack.org/cgit/openstack/tap-as-a-service/commit/?id=38f1ab3bd26e7188144367363a385ee913d7d8e0
Submitter: Jenkins
Branch: master

commit 38f1ab3bd26e7188144367363a385ee913d7d8e0
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Jun 7 14:29:47 2016 +0900

    Use call_and_ignore_notfound_exc directly

    This patch makes service client use call_and_ignore_notfound_exc
    directly because the client only uses it.

    Co-Authored-By: Ken'ichi Ohmichi <email address hidden>
    Closes-Bug: #1589521
    Change-Id: I8ee81502a090aa0581e0b46b96bfa6144b456cc4

Changed in tap-as-a-service:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron-fwaas 9.0.0.0b2

This issue was fixed in the openstack/neutron-fwaas 9.0.0.0b2 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron-fwaas 8.2.0

This issue was fixed in the openstack/neutron-fwaas 8.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.