macvtap: agent starts although no interface_mapping is provided

Bug #1587444 reported by Andreas Scheuring
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Andreas Scheuring

Bug Description

As the macvtap agent does only support flat and vlan networks, the physical_interface_mappings prameter must contain at least one mapping. Without a mapping, no networkconnectivity can be provided by this agent.

Ideally the agent would terminate with an appropriate error message pointing the operator to this issue.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/323398

Changed in neutron:
assignee: nobody → Andreas Scheuring (andreas-scheuring)
status: New → In Progress
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in neutron:
assignee: Andreas Scheuring (andreas-scheuring) → nobody
status: In Progress → Incomplete
Changed in neutron:
importance: Undecided → High
tags: added: ocata-rc-potential
Changed in neutron:
milestone: none → ocata-rc1
assignee: nobody → Andreas Scheuring (andreas-scheuring)
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/323398
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=557e0c0a4c95c4b1e556f8aaf351937a237c7cd9
Submitter: Jenkins
Branch: master

commit 557e0c0a4c95c4b1e556f8aaf351937a237c7cd9
Author: Andreas Scheuring <email address hidden>
Date: Tue May 31 15:54:38 2016 +0200

    Terminate macvtap agent when physical_interface_mapping config not present

    Starting the macvtap agent without specifying at least one
    physical_interface_mappings does not make sense. As it only
    supports layer2 networks (flat, vlan) an interface mapping is
    mandatory. An existing agent deployment without an interface
    mapping can not serve any networks to instances!

    This patch terminates the agent when no mapping is
    provided. As without this mapping the agent cannot serve any networks
    for instances, this patch can't really break existing deployments.

    UpgradeImpact Agent terminates when no physical_interface_mapping
    configuration is provided.

    Change-Id: I647cf4da55fda54e32b7047b84e0d7f671629fa7
    Closes-Bug: #1587444

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/429794

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ocata)

Reviewed: https://review.openstack.org/429794
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f7b1fc6c80d38ba66da89dbe57f307297ee416c4
Submitter: Jenkins
Branch: stable/ocata

commit f7b1fc6c80d38ba66da89dbe57f307297ee416c4
Author: Andreas Scheuring <email address hidden>
Date: Tue May 31 15:54:38 2016 +0200

    Terminate macvtap agent when physical_interface_mapping config not present

    Starting the macvtap agent without specifying at least one
    physical_interface_mappings does not make sense. As it only
    supports layer2 networks (flat, vlan) an interface mapping is
    mandatory. An existing agent deployment without an interface
    mapping can not serve any networks to instances!

    This patch terminates the agent when no mapping is
    provided. As without this mapping the agent cannot serve any networks
    for instances, this patch can't really break existing deployments.

    UpgradeImpact Agent terminates when no physical_interface_mapping
    configuration is provided.

    Change-Id: I647cf4da55fda54e32b7047b84e0d7f671629fa7
    Closes-Bug: #1587444
    (cherry picked from commit 557e0c0a4c95c4b1e556f8aaf351937a237c7cd9)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.0.0rc2

This issue was fixed in the openstack/neutron 10.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b1

This issue was fixed in the openstack/neutron 11.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.