[LBaaS] test_models_sync is skipped in UT due to the backend unavailability

Bug #1585116 reported by Elena Ezhova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Elena Ezhova

Bug Description

According to [1] access to MySQL/PostgreSQL is no longer in unittests by default. That's why tests for models and migrations sync are currently getting skipped in neutron-lbaas. Model migration tests should run as functional tests like they do in neutron and fail if db backend is unavailable, unless OS_FAIL_ON_MISSING_DEPS is disabled.

[1]http://lists.openstack.org/pipermail/openstack-dev/2016-March/090052.html

Elena Ezhova (eezhova)
tags: added: lbaas
Changed in neutron:
assignee: nobody → Elena Ezhova (eezhova)
Changed in neutron:
importance: Undecided → Medium
Changed in neutron:
status: New → In Progress
Revision history for this message
Elena Ezhova (eezhova) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-lbaas (master)

Reviewed: https://review.openstack.org/320998
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=b68c0e27e3f52238dce048ead2538fdabe179e06
Submitter: Jenkins
Branch: master

commit b68c0e27e3f52238dce048ead2538fdabe179e06
Author: Elena Ezhova <email address hidden>
Date: Wed May 25 16:40:44 2016 +0300

    Refactor gate hooks

    The aim of this change is to make gate_hook and post_test_hook
    more generic and prepare base for adding a new functional job
    and tests. The patch also includes a number cosmetic changes
    which should make the hooks' code easier to read.

    - Moved all argument parsing to decode_args.sh.
    - gate_hook: Extracted code related to configuring Octavia into a
      separate function.
    - post_test_hook: Filling test_subset is not required if the aim
      is to run all set (api-* job).
    - post_test_hook: Don't set OS_TEST_PATH and OS_TESTR_CONCURRENCY
      as it's also done in tox.ini.
    - Style fixes.

    Depends-On: Ib5e34f67209394eff43da7e5b5f722f4888deb0b
    Change-Id: I32eaa12fb27a4cfbd09bd20e9821ebd310c32e44
    Related-Bug: #1585116

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-lbaas (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/329924

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-lbaas (stable/mitaka)

Reviewed: https://review.openstack.org/329924
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=c502db8400ee7cde42eb506623d7a818afaa3f02
Submitter: Jenkins
Branch: stable/mitaka

commit c502db8400ee7cde42eb506623d7a818afaa3f02
Author: Franklin Naval <email address hidden>
Date: Fri May 13 14:59:13 2016 -0500

    Fix stable/mitaka gate failures

    This change is squashed from backports of
    0b6a3fbdfab9768287205d278061a63204869e5d and
    b68c0e27e3f52238dce048ead2538fdabe179e06. These two bugfixes
    form a circular depencency and can't be merged without each
    other.

    The other way to solve this deadlock is to revert
    https://review.openstack.org/322811 and
    https://review.openstack.org/320998, merge
    https://review.openstack.org/321563 and then start
    anew.

    Here are the commit messages of both changes:

    Neutron-LBaaS: Fix network_resources path

    * upstream tempest changed the namespace for
      network_resources, this change updates that path
    * fixed changed deprecated config parameters
    * replaced network_cilent passed into DeletableSubnet
      with subnets_client and routers_client

    Refactor gate hooks

    The aim of this change is to make gate_hook and post_test_hook
    more generic and prepare base for adding a new functional job
    and tests. The patch also includes a number cosmetic changes
    which should make the hooks' code easier to read.

    - Moved all argument parsing to decode_args.sh.
    - gate_hook: Extracted code related to configuring Octavia into a
      separate function.
    - post_test_hook: Filling test_subset is not required if the aim
      is to run all set (api-* job).
    - post_test_hook: Don't set OS_TEST_PATH and OS_TESTR_CONCURRENCY
      as it's also done in tox.ini.
    - Style fixes.

    Change-Id: I32eaa12fb27a4cfbd09bd20e9821ebd310c32e44
    Closes-Bug: #1581660
    Closes-Bug: #1592564
    Related-Bug: #1585116

tags: added: in-stable-mitaka
Changed in neutron:
assignee: Elena Ezhova (eezhova) → Armando Migliaccio (armando-migliaccio)
Elena Ezhova (eezhova)
Changed in neutron:
assignee: Armando Migliaccio (armando-migliaccio) → Elena Ezhova (eezhova)
Changed in neutron:
assignee: Elena Ezhova (eezhova) → Brandon Logan (brandon-logan)
Elena Ezhova (eezhova)
Changed in neutron:
assignee: Brandon Logan (brandon-logan) → Elena Ezhova (eezhova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lbaas (master)

Reviewed: https://review.openstack.org/320999
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=2317364c31c971c74b97fe17374624652816a123
Submitter: Jenkins
Branch: master

commit 2317364c31c971c74b97fe17374624652816a123
Author: Elena Ezhova <email address hidden>
Date: Wed May 25 16:42:09 2016 +0300

    Set up hooks for the functional job and add test_migrations test

    Add gate hooks for the dsvm-functional job including set-up of
    configure_for_lbaas_func_testing.sh script and corresponding changes to
    tox.ini.

    PyMySQL dependency was moved from test_requirements.txt to
    functional/requirements.txt.

    test_migrations.py was moved from unit tests to functional in
    order to prevent it from being skipped in case of db backend
    unavailability.

    Fixed failing TestModelsMigrations test by importing modules with
    missing models in db/models/head.py

    Closes-Bug: #1585116
    Closes-Bug: #1596984
    Change-Id: Ic39805ea0ed330ef7da82043f77077e8a5617ca0

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron-lbaas 9.0.0.0b2

This issue was fixed in the openstack/neutron-lbaas 9.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.