Move dns related data field out of ml2 plugin into dns plugin

Bug #1579601 reported by bin Yu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
bin Yu

Bug Description

Now, We prefer to enable DNS support in Neutron by enabling the extension_drivers in Neutron plugin configurations. However, we still have the dns related data in ml2 core plugin like dns_name in ports data fields.

We prefer to remove the code section like "if ('dns-integration' in self.supported_extension_aliases and 'dns_name' in p)" out of db_base_plugin_v2.py

and code like
   if "dns_name" in port:
             res["dns_name"] = port["dns_name"]
out of db_base_plugin_common.py.

The goal is to let the dns plugin handle the dns request, and the core plugin calling the dns plugin through the method like extension_drivers and app_dict. we hope to hide the detail of dns information from the prespective of core plugin.

Tags: dns
bin Yu (froyo-bin)
Changed in neutron:
assignee: nobody → bin Yu (froyo-bin)
Changed in neutron:
status: New → In Progress
Revision history for this message
Ryan Moats (rmoats) wrote : Re: [RFE] move dns related data field out of ml2 plugin into dns plugin

armax, this reads more like an RFE to me, so I have tagged it as such.

tags: added: rfe
summary: - move dns related data field out of ml2 plugin into dns plugin
+ [RFE] move dns related data field out of ml2 plugin into dns plugin
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This is code refactoring. Miguel Lavalle should be able to provide more input.

summary: - [RFE] move dns related data field out of ml2 plugin into dns plugin
+ Move dns related data field out of ml2 plugin into dns plugin
Changed in neutron:
importance: Undecided → Low
tags: removed: rfe
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

https://review.openstack.org/#/c/313291/

I don't quite see why we need the data migration though.

Changed in neutron:
assignee: bin Yu (froyo-bin) → Carl Baldwin (carl-baldwin)
Miguel Lavalle (minsel)
Changed in neutron:
assignee: Carl Baldwin (carl-baldwin) → bin Yu (froyo-bin)
Changed in neutron:
assignee: bin Yu (froyo-bin) → Manjeet Singh Bhatia (manjeet-s-bhatia)
Changed in neutron:
assignee: Manjeet Singh Bhatia (manjeet-s-bhatia) → bin Yu (froyo-bin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/313291
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=64f5fc82596ec6b78b76ca5d9cfc1d4b5a0b975d
Submitter: Jenkins
Branch: master

commit 64f5fc82596ec6b78b76ca5d9cfc1d4b5a0b975d
Author: Bin Yu <email address hidden>
Date: Fri May 6 17:20:04 2016 +0800

    Refactor DNS integration out of DB core plugin

    This patch set aims to move all the code related to DNS integration
    from the DB core plugin to the DNS ML2 extension module.

    By doing this, this patchset removes the dns related code in
    db_base_plugin_v2 and the dns exteions module talks with core plugin
    only through the method extension_manager and apply_dict_extend_functions

    By properly implementing the generation of the dns_assignment attribute
    for ports in the DNS ML2 extension module, this patchset also fixes
    https://bugs.launchpad.net/neutron/+bug/1579977

    Change-Id: I63afb1a1bfeeb14eefb54681dc64959144deeb25
    Closes-Bug: #1579601
    Closes-Bug: #1579977

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 9.0.0.0b3

This issue was fixed in the openstack/neutron 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.