SRIOV: ESwitchManager should handle multiple NICs per physical net

Bug #1576757 reported by Oleg Bondarev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Elena Ezhova

Bug Description

Commit 46ddaf4288a1cac44d8afc0525b4ecb3ae2186a3 made it possible to specify multiple NICs per network.
However ESwitchManager now stores only one EmbSwitch per physical net (the last one).

Changed in neutron:
assignee: Vladimir Eremin (yottatsa) → Oleg Bondarev (obondarev)
status: Confirmed → In Progress
Changed in neutron:
assignee: Oleg Bondarev (obondarev) → Elena Ezhova (eezhova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/310927
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ea5fce2c91ae166fe2112ae4418940299d80ab13
Submitter: Jenkins
Branch: master

commit ea5fce2c91ae166fe2112ae4418940299d80ab13
Author: Vladimir Eremin <email address hidden>
Date: Thu Apr 28 15:14:18 2016 -0500

    Fix SR-IOV binding when two NICs mapped to one physnet

    Because ESwitchManager._create_emb_switch stores one EmbSwitch per
    physnet, there is only last EmbSwitch works if two NICs was configured
    for one physnet:
    physical_device_mappings=physnet2:ens3f0,physnet2:ens3f1

    This patch makes ESwitchManager.emb_switches_map store a list of
    EmbSwitch for physnet.

    Also fixed usage of singleton ESwitchManager class in tests by
    adding cleanup.

    Change-Id: I4fd9849890a770ea2b00063b546cc73a0f2d754c
    Closes-Bug: #1576757

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/316676

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/mitaka)

Reviewed: https://review.openstack.org/316676
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=30a849eb0e96da4d24d4dfd6718f23548f119b92
Submitter: Jenkins
Branch: stable/mitaka

commit 30a849eb0e96da4d24d4dfd6718f23548f119b92
Author: Vladimir Eremin <email address hidden>
Date: Thu Apr 28 15:14:18 2016 -0500

    Fix SR-IOV binding when two NICs mapped to one physnet

    Because ESwitchManager._create_emb_switch stores one EmbSwitch per
    physnet, there is only last EmbSwitch works if two NICs was configured
    for one physnet:
    physical_device_mappings=physnet2:ens3f0,physnet2:ens3f1

    This patch makes ESwitchManager.emb_switches_map store a list of
    EmbSwitch for physnet.

    Also fixed usage of singleton ESwitchManager class in tests by
    adding cleanup.

    Change-Id: I4fd9849890a770ea2b00063b546cc73a0f2d754c
    Closes-Bug: #1576757
    (cherry picked from commit ea5fce2c91ae166fe2112ae4418940299d80ab13)

tags: added: in-stable-mitaka
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.1.1

This issue was fixed in the openstack/neutron 8.1.1 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

tags: removed: mitaka-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.