subnet unusable after updating it

[Kevin Benton]

After updating a subnet (e.g. the name or the dhcp_enabled flag), I'm no longer able to create ports on the subnet due to an error indicating there are no more IP addresses available.

This was found with ipam_driver = internal

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/309297

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/313199

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309297
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4d6fe0c38ba5ab822f272af2a892093a315d356a
Submitter: Jenkins
Branch: master

commit 4d6fe0c38ba5ab822f272af2a892093a315d356a
Author: Kevin Benton <email address hidden>
Date: Thu Apr 21 19:40:07 2016 -0700

    Use correct session in update_allocation_pools

    This fixes the IP driver update_allocation_pools to use
    the session on the subnet rather than generating a new one.
    Generating a new one was causing the allocation pool
    creation to be uncommitted since nothing was ever starting
    a transaction on the session before it added allocation pool
    objects to the session. This resulted in them never being
    committed to the database so the subnet would become unusable
    after an update.

    This also adds a very simple unit test to ensure the
    subnet still works after an update.

    Closes-Bug: #1573443
    Change-Id: I1c80a01f475760b9cd405fc89ee2df3a4a1c26c4

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/315281

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/313199
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8825166f5b2811f6a1f1ca48987f63caa7bdf70a
Submitter: Jenkins
Branch: stable/mitaka

commit 8825166f5b2811f6a1f1ca48987f63caa7bdf70a
Author: Kevin Benton <email address hidden>
Date: Thu Apr 21 19:40:07 2016 -0700

    Use correct session in update_allocation_pools

    This fixes the IP driver update_allocation_pools to use
    the session on the subnet rather than generating a new one.
    Generating a new one was causing the allocation pool
    creation to be uncommitted since nothing was ever starting
    a transaction on the session before it added allocation pool
    objects to the session. This resulted in them never being
    committed to the database so the subnet would become unusable
    after an update.

    This also adds a very simple unit test to ensure the
    subnet still works after an update.

    Closes-Bug: #1573443
    Change-Id: I1c80a01f475760b9cd405fc89ee2df3a4a1c26c4
    (cherry picked from 4d6fe0c38ba5ab822f272af2a892093a315d356a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309225
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d2eb6f70ac111d672a0f5ae85565921f82e28108
Submitter: Jenkins
Branch: master

commit d2eb6f70ac111d672a0f5ae85565921f82e28108
Author: Kevin Benton <email address hidden>
Date: Thu Apr 21 17:39:26 2016 -0700

    Add test that ensures subnet is usable after update

    Adds a simple test to make sure a port can be created
    on a subnet after disabling DHCP.

    Related-Bug: #1573443
    Change-Id: I94f1a59e52b109984904fd9e56e3c1a3f1c270fe

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/315281
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fd240c1bc68cb96a5f1c0b531b4ee213e60f555a
Submitter: Jenkins
Branch: stable/liberty

commit fd240c1bc68cb96a5f1c0b531b4ee213e60f555a
Author: Kevin Benton <email address hidden>
Date: Thu Apr 21 19:40:07 2016 -0700

    Use correct session in update_allocation_pools

    This fixes the IP driver update_allocation_pools to use
    the session on the subnet rather than generating a new one.
    Generating a new one was causing the allocation pool
    creation to be uncommitted since nothing was ever starting
    a transaction on the session before it added allocation pool
    objects to the session. This resulted in them never being
    committed to the database so the subnet would become unusable
    after an update.

    This also adds a very simple unit test to ensure the
    subnet still works after an update.

    Closes-Bug: #1573443
    Change-Id: I1c80a01f475760b9cd405fc89ee2df3a4a1c26c4
    (cherry picked from commit 4d6fe0c38ba5ab822f272af2a892093a315d356a)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.1.1 release.

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 7.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.