test_setup_reserved_with_isolated_metadata_enable

[Ihar Hrachyshka]

http://logs.openstack.org/74/268274/35/check/gate-neutron-python27/3de5871/testr_results.html.gz

ft54.5: neutron.tests.unit.agent.linux.test_dhcp.TestDeviceManager.test_setup_reserved_with_isolated_metadata_enable_StringException: Empty attachments:
  pythonlogging:''
  stderr
  stdout

Traceback (most recent call last):
  File "neutron/tests/unit/agent/linux/test_dhcp.py", line 2122, in test_setup_reserved_with_isolated_metadata_enable
    self._test_setup_reserved(enable_isolated_metadata=True)
  File "neutron/tests/unit/agent/linux/test_dhcp.py", line 2101, in _test_setup_reserved
    mgr.setup(network)
  File "neutron/agent/linux/dhcp.py", line 1219, in setup
    port = self.setup_dhcp_port(network)
  File "neutron/agent/linux/dhcp.py", line 1191, in setup_dhcp_port
    for fixed_ip in dhcp_port.fixed_ips]
TypeError: 'Mock' object is not iterable

To reproduce locally,

python -m testtools.run neutron.tests.unit.agent.linux.test_dhcp.TestDeviceManager

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/304851

[Henry Gessau (gessau)]

This bug was introduced by https://review.openstack.org/286345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/304917
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=61e76a34f322828572882ef66598b3da58ef36bc
Submitter: Jenkins
Branch: master

commit 61e76a34f322828572882ef66598b3da58ef36bc
Author: Henry Gessau <email address hidden>
Date: Wed Apr 13 00:45:10 2016 +0000

    Revert "Add 169.254.169.254 when enable force_metadata"

    This reverts commit 45bec12cfc27578597cd197334979d0aee73a2cf.

    Closes-bug: #1569507

    Change-Id: Ie605f3b848a35b5db545c69038249155477d71e0

[OpenStack Infra (hudson-openstack)]

Change abandoned by Darek Smigiel (<email address hidden>) on branch: master
Review: https://review.openstack.org/304851
Reason: Initial patch, which caused this problem, reverted here: https://review.openstack.org/#/c/304917/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/306672

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/306672
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7e79137acc060db00c50fb8f0190768df0eb1296
Submitter: Jenkins
Branch: master

commit 7e79137acc060db00c50fb8f0190768df0eb1296
Author: Henry Gessau <email address hidden>
Date: Fri Apr 15 09:25:35 2016 -0400

    Move class properties to instances for dhcp tests

    Using class properties for tests always carries the risk of
    conflicting use between test cases when tests are run in parallel.

    Related-Bug: #1569507

    Change-Id: I5868dd8e3c2293be26fd7c99338f7c979f727533

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/307398

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/307398
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d87b37876abdb89b89b40aeefba0fcae86efde41
Submitter: Jenkins
Branch: master

commit d87b37876abdb89b89b40aeefba0fcae86efde41
Author: Henry Gessau <email address hidden>
Date: Mon Apr 18 14:05:42 2016 -0400

    Move class properties to instances for dhcp/test_agent.py

    Using class properties for tests always carries the risk of
    conflicting use between test cases when tests are run in parallel.

    Change-Id: I41034001a8674ad208c57f2f60266769390f924b
    Related-Bug: #1569507

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/393404

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/393404
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=67d85562f5a9f6cf1dca14c249f4841e130144b8
Submitter: Jenkins
Branch: stable/mitaka

commit 67d85562f5a9f6cf1dca14c249f4841e130144b8
Author: Henry Gessau <email address hidden>
Date: Fri Apr 15 09:25:35 2016 -0400

    Move class properties to instances for dhcp tests

    Using class properties for tests always carries the risk of
    conflicting use between test cases when tests are run in parallel.

    Related-Bug: #1569507

    Change-Id: I5868dd8e3c2293be26fd7c99338f7c979f727533
    (cherry picked from commit 7e79137acc060db00c50fb8f0190768df0eb1296)