tox -e py27 is failing due to fixtures 2.0.0 release

Bug #1567295 reported by vikas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Liberty
Fix Released
Undecided
Unassigned
neutron
Fix Released
High
Gary Kotton

Bug Description

unit test cases were failing due to below error

networking_l2gw.tests.unit.services.l2gateway.service_drivers.test_rpc_l2gw.TestL2gwRpcDriver.test_validate_connection
----------------------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "networking_l2gw/tests/unit/services/l2gateway/service_drivers/test_rpc_l2gw.py", line 42, in setUp
        self.plugin = rpc_l2gw.L2gwRpcDriver(self.service_plugin)
      File "networking_l2gw/services/l2gateway/service_drivers/rpc_l2gw.py", line 62, in __init__
        self.conn.consume_in_threads()
    TypeError: fake_consume_in_threads() takes exactly 1 argument (0 given)

vikas (vikas-d-m)
Changed in networking-l2gw:
assignee: nobody → vikas (vikas-d-m)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-l2gw (master)

Fix proposed to branch: master
Review: https://review.openstack.org/302613

Changed in networking-l2gw:
status: New → In Progress
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote : Re: tox -e py27 is failing

New fixtures release broke all neutron repos.

Changed in neutron:
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)
importance: Undecided → Critical
importance: Critical → High
tags: added: gate-failure
Changed in neutron:
status: New → In Progress
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Note it does not affect neutron/master because of upper-constraints.txt applied. But we need to fix and backport it up to kilo nevertheless.

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Nah, Kilo is not affected. It affects Liberty+ only because in Kilo the version for fixtures is capped to <1.3.x.

tags: added: liberty-backport-potential mitaka-backport-potential
Changed in networking-l2gw:
status: In Progress → Invalid
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

It's not a bug to fix in subprojects, I moved l2gw component bug to Invalid.

no longer affects: networking-l2gw
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/302997

Changed in neutron:
assignee: Ihar Hrachyshka (ihar-hrachyshka) → Gary Kotton (garyk)
Revision history for this message
Matt Riedemann (mriedem) wrote :

I'm not sure why mitaka and liberty backport potential are in here, we shouldn't be using fixtures 2.0.0 in mitaka or liberty because it's not used in upper-constraints on those branches.

summary: - tox -e py27 is failing
+ tox -e py27 is failing due to fixtures 2.0.0 release
Revision history for this message
Matt Riedemann (mriedem) wrote :
Revision history for this message
Matt Riedemann (mriedem) wrote :
Revision history for this message
Matt Riedemann (mriedem) wrote :

Temporary cap on fixtures in g-r for now: https://review.openstack.org/#/c/303034/

Revision history for this message
Matt Riedemann (mriedem) wrote :
Matt Riedemann (mriedem)
Changed in nova:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/302997
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2af86b8f6f749bf7b42a2c04b48c9a2dc28a46c9
Submitter: Jenkins
Branch: master

commit 2af86b8f6f749bf7b42a2c04b48c9a2dc28a46c9
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Apr 7 19:15:01 2016 +0200

    Switched from fixtures to mock to mock out starting RPC consumers

    fixtures 2.0.0 broke us wildly, so instead of trying to make it work
    with new fixtures, I better just switch the mock to... mock.

    Change-Id: I58d7a750e263e4af54589ace07ac00bec34b553a
    Closes-Bug: #1567295

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/303285

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/303286

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Matt, while gate constraints are indeed in effect for Mitaka and Liberty, the g-r depedency allows 2.0.0, so we probably better fix it in case someone does not rely on constraints.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/303292

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/303293

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/kilo)

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/303286
Reason: Sorry, but it's not needed in Kilo (we cap fixtures in the branch).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/liberty)

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/303285
Reason: Sorry, this patch has wrong format. Correct one: https://review.openstack.org/#/c/303293/1 (note Change-Id, also no topic changed).

Revision history for this message
Matt Riedemann (mriedem) wrote :

Nova is passing on master now since we capped fixtures<2.0. stable/liberty unit test jobs for nova are failing because they aren't using constraints. The stable/mitaka unit test jobs are OK though since they use constraints.

Revision history for this message
Matt Riedemann (mriedem) wrote :

This series will get nova using constraints for tox jobs in stable/liberty: https://review.openstack.org/#/q/topic:lib_constraints

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/303293
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=275a1714e88fb7d407612df7198804cb7a4f3165
Submitter: Jenkins
Branch: stable/liberty

commit 275a1714e88fb7d407612df7198804cb7a4f3165
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Apr 7 19:15:01 2016 +0200

    Switched from fixtures to mock to mock out starting RPC consumers

    fixtures 2.0.0 broke us wildly, so instead of trying to make it work
    with new fixtures, I better just switch the mock to... mock.

    Change-Id: I58d7a750e263e4af54589ace07ac00bec34b553a
    Closes-Bug: #1567295
    (cherry picked from commit 2af86b8f6f749bf7b42a2c04b48c9a2dc28a46c9)
    (cherry picked from commit ee32ea5e2bf2b01104c5bde6b6a5018dd0e15f57)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by garyk (<email address hidden>) on branch: master
Review: https://review.openstack.org/302737

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/mitaka)

Reviewed: https://review.openstack.org/303292
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ee32ea5e2bf2b01104c5bde6b6a5018dd0e15f57
Submitter: Jenkins
Branch: stable/mitaka

commit ee32ea5e2bf2b01104c5bde6b6a5018dd0e15f57
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Apr 7 19:15:01 2016 +0200

    Switched from fixtures to mock to mock out starting RPC consumers

    fixtures 2.0.0 broke us wildly, so instead of trying to make it work
    with new fixtures, I better just switch the mock to... mock.

    Change-Id: I58d7a750e263e4af54589ace07ac00bec34b553a
    Closes-Bug: #1567295
    (cherry picked from commit 2af86b8f6f749bf7b42a2c04b48c9a2dc28a46c9)

tags: added: in-stable-mitaka
Changed in nova:
assignee: nobody → Sharat Sharma (sharat-sharma)
status: Confirmed → In Progress
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 8.1.0

This issue was fixed in the openstack/neutron 8.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/314250

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)
Download full text (36.9 KiB)

Reviewed: https://review.openstack.org/314250
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3bf73801df169de40d365e6240e045266392ca63
Submitter: Jenkins
Branch: master

commit a323769143001d67fd1b3b4ba294e59accd09e0e
Author: Ryan Moats <email address hidden>
Date: Tue Oct 20 15:51:37 2015 +0000

    Revert "Improve performance of ensure_namespace"

    This reverts commit 81823e86328e62850a89aef9f0b609bfc0a6dacd.

    Unneeded optimization: this commit only improves execution
    time on the order of milliseconds, which is less than 1% of
    the total router update execution time at the network node.

    This also

    Closes-bug: #1574881

    Change-Id: Icbcdf4725ba7d2e743bb6761c9799ae436bd953b

commit 7fcf0253246832300f13b0aa4cea397215700572
Author: OpenStack Proposal Bot <email address hidden>
Date: Thu Apr 21 07:05:16 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I9e930750dde85a9beb0b6f85eeea8a0962d3e020

commit 643b4431606421b09d05eb0ccde130adbf88df64
Author: OpenStack Proposal Bot <email address hidden>
Date: Tue Apr 19 06:52:48 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I52d7460b3265b5460b9089e1cc58624640dc7230

commit 1ffea42ccdc14b7a6162c1895bd8f2aae48d5dae
Author: OpenStack Proposal Bot <email address hidden>
Date: Mon Apr 18 15:03:30 2016 +0000

    Updated from global requirements

    Change-Id: Icb27945b3f222af1d9ab2b62bf2169d82b6ae26c

commit b970ed5bdac60c0fa227f2fddaa9b842ba4f51a7
Author: Kevin Benton <email address hidden>
Date: Fri Apr 8 17:52:14 2016 -0700

    Clear DVR MAC on last agent deletion from host

    Once all agents are deleted from a host, the DVR MAC generated
    for that host should be deleted as well to prevent a buildup of
    pointless flows generated in the OVS agent for hosts that don't
    exist.

    Closes-Bug: #1568206
    Change-Id: I51e736aa0431980a595ecf810f148ca62d990d20
    (cherry picked from commit 92527c2de2afaf4862fddc101143e4d02858924d)

commit eee9e58ed258a48c69effef121f55fdaa5b68bd6
Author: Mike Bayer <email address hidden>
Date: Tue Feb 9 13:10:57 2016 -0500

    Add an option for WSGI pool size

    Neutron currently hardcodes the number of
    greenlets used to process requests in a process to 1000.
    As detailed in
    http://lists.openstack.org/pipermail/openstack-dev/2015-December/082717.html

    this can cause requests to wait within one process
    for available database connection while other processes
    remain available.

    By adding a wsgi_default_pool_size option functionally
    identical to that of Nova, we can lower the number of
    greenlets per process to be more in line with a typical
    max database connection pool size.

    DocImpact: a previously unused configuration value
               wsgi_default_pool_size is now used to a...

tags: added: neutron-proactive-backport-potential
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 7.1.0

This issue was fixed in the openstack/neutron 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

tags: removed: neutron-proactive-backport-potential
tags: removed: liberty-backport-potential mitaka-backport-potential
Sean Dague (sdague)
no longer affects: nova
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.