The creation fip does not endure restarting of l3-agent

Bug #1566383 reported by QingchuanHao
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
High
Brian Haley

Bug Description

when creating the first floating ip of a router, the veth-pair(fpr and rfp) will be created. But if I3-agent is restarted accidentally before assigning locally allocated ip for the fpr or rfp, gateway will not be added successfully with and error raised

Changed in neutron:
assignee: nobody → QingchuanHao (haoqingchuan-28)
Reedip (reedip-banerjee)
tags: added: l3-ipam-dhcp
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/302340

Changed in neutron:
status: New → In Progress
Revision history for this message
Carl Baldwin (carl-baldwin) wrote :

It is helpful to have the details of the error raised. But, I'll go look at the fix. Maybe it will be apparent.

Changed in neutron:
assignee: QingchuanHao (haoqingchuan-28) → Brian Haley (brian-haley)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/309591

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/309592

tags: added: l3-dvr-backlog
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/309591
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b9bec4be6ba06087ebfa20007dcbc2cb646a5345
Submitter: Jenkins
Branch: master

commit b9bec4be6ba06087ebfa20007dcbc2cb646a5345
Author: Brian Haley <email address hidden>
Date: Fri Apr 22 15:43:24 2016 -0400

    DVR: Use IPDevice class consistently

    create_rtr_2_fip_link() only creates IPDevice class instances
    after it determines the VETH pair does not exist. Change to
    always create them as instead of using int_dev[0]. This is
    also setup for a follow-on patch.

    Partial-Bug: #1566383
    Change-Id: I58e242f05ffb9a33bda5aeb93344861769845d2e

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/309592
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=17cfffbbfa57ccec54c7e06518b5e7e8a00e0c51
Submitter: Jenkins
Branch: master

commit 17cfffbbfa57ccec54c7e06518b5e7e8a00e0c51
Author: Brian Haley <email address hidden>
Date: Fri Apr 22 16:09:07 2016 -0400

    DVR: Use existing IPDevice to add address on FIP VETH

    create_rtr_2_fip_link() has IPDevice instances for each
    end of the VETH pair it created, just use them to add the
    link-local IP to each one. Because this is a point-to-point
    link, we don't add the broadcast address when we assign the IP,
    so add a flag to IpAddrCommand() class to accomodate us.
    This is also setup for a follow-on patch.

    Partial-Bug: #1566383
    Change-Id: I66d70afaf3c52861e0887d3f535d5327ea46b128

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/302340
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a47d22942a46cf12589cee6353dc2b6deb58f178
Submitter: Jenkins
Branch: master

commit a47d22942a46cf12589cee6353dc2b6deb58f178
Author: Brian Haley <email address hidden>
Date: Thu May 5 10:07:36 2016 -0400

    DVR: Ensure fpr and rfp devices are configured correctly

    Restarting the l3-agent when creating the fip namespace may
    leave rfp and fpr devices with no IP addresses, since we will
    not try and configure them if the devices already exist.

    Fix this by always trying to configure the IP addresses,
    even if the devices already exist.

    Closes-Bug: #1566383
    Change-Id: Idad3bb4808ec66b9a764bb621dfb04a10eb7ed6

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/314722

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/314762

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/314767

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/mitaka)

Change abandoned by Swaminathan Vasudevan (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/314767

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Swaminathan Vasudevan (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/314762
Reason: abandon

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Swaminathan Vasudevan (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/314722
Reason: adandon

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/314790

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/314801

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/314804

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/320098

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/320101

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/mitaka)

Change abandoned by Swaminathan Vasudevan (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/314790
Reason: Alternate patch with correct change-id uploaded.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Swaminathan Vasudevan (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/314801
Reason: Alternate patch with correct change-id uploaded.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/mitaka)

Reviewed: https://review.openstack.org/320098
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5d57c7c89e3407cbb17a1e30e67dc76d5168867d
Submitter: Jenkins
Branch: stable/mitaka

commit 5d57c7c89e3407cbb17a1e30e67dc76d5168867d
Author: Brian Haley <email address hidden>
Date: Fri Apr 22 15:43:24 2016 -0400

    DVR: Use IPDevice class consistently

    create_rtr_2_fip_link() only creates IPDevice class instances
    after it determines the VETH pair does not exist. Change to
    always create them as instead of using int_dev[0]. This is
    also setup for a follow-on patch.

    Partial-Bug: #1566383
    Change-Id: I58e242f05ffb9a33bda5aeb93344861769845d2e
    (cherry picked from commit b9bec4be6ba06087ebfa20007dcbc2cb646a5345)
    Conflicts:
     neutron/agent/l3/dvr_fip_ns.py

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/320101
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b6d99239cf12291169305b7f79dda21e88c670ee
Submitter: Jenkins
Branch: stable/mitaka

commit b6d99239cf12291169305b7f79dda21e88c670ee
Author: Brian Haley <email address hidden>
Date: Fri Apr 22 16:09:07 2016 -0400

    DVR: Use existing IPDevice to add address on FIP VETH

    create_rtr_2_fip_link() has IPDevice instances for each
    end of the VETH pair it created, just use them to add the
    link-local IP to each one. Because this is a point-to-point
    link, we don't add the broadcast address when we assign the IP,
    so add a flag to IpAddrCommand() class to accomodate us.
    This is also setup for a follow-on patch.

    Partial-Bug: #1566383
    Change-Id: I66d70afaf3c52861e0887d3f535d5327ea46b128
    (cherry picked from commit 17cfffbbfa57ccec54c7e06518b5e7e8a00e0c51)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/314804
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=18bb187632511191cb8c84133462cc838c6fc67c
Submitter: Jenkins
Branch: stable/mitaka

commit 18bb187632511191cb8c84133462cc838c6fc67c
Author: Brian Haley <email address hidden>
Date: Thu May 5 10:07:36 2016 -0400

    DVR: Ensure fpr and rfp devices are configured correctly

    Restarting the l3-agent when creating the fip namespace may
    leave rfp and fpr devices with no IP addresses, since we will
    not try and configure them if the devices already exist.

    Fix this by always trying to configure the IP addresses,
    even if the devices already exist.

    Closes-Bug: #1566383
    (cherry picked from commit a47d22942a46cf12589cee6353dc2b6deb58f178)

    Change-Id: Idad3bb4808ec66b9a764bb621dfb04a10eb7ed6

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/neutron 8.1.2

This issue was fixed in the openstack/neutron 8.1.2 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers