Add enable_dhcp filter in get_network_info rpc

Bug #1552614 reported by yaowei
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Mamatisa Nurmatov

Bug Description

As code in
https://github.com/openstack/neutron/blob/master/neutron/api/rpc/handlers/dhcp_rpc.py#L163

the rpc get_active_network called by dhcp-agent to fetch network info, and subnet which enable_dhcp = False is not needed.

It would better add 'enable_dhcp=True' into filter and recheck in dhcp agent would not need.

https://github.com/openstack/neutron/blob/master/neutron/agent/linux/dhcp.py#L344

Changed in neutron:
assignee: nobody → yaowei (yaowei)
Changed in neutron:
status: New → Confirmed
importance: Undecided → Low
tags: added: l3-ipam-dhcp
Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/289165

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/289165
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
status: In Progress → Incomplete
tags: added: low-hanging-fruit
Changed in neutron:
assignee: yaowei (yaowei) → nobody
Changed in neutron:
assignee: nobody → Haidee McMahon (haidee-mcmahon)
Changed in neutron:
assignee: Haidee McMahon (haidee-mcmahon) → Mamatisa Nurmatov (isabek)
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/289165
Committed: https://opendev.org/openstack/neutron/commit/1483b63ffaf933903abf7317b03a99195a71c98a
Submitter: "Zuul (22348)"
Branch: master

commit 1483b63ffaf933903abf7317b03a99195a71c98a
Author: Nurmatov Mamatisa <email address hidden>
Date: Thu Apr 8 18:48:29 2021 +0300

    Add enable_dhcp filter in get_network_info rpc

    Add enable_dhcp, to make a filter to avoid unnecessary
    net_info data transfer through rpc.

    Change-Id: Ibcef366f5b1f4b7da4f47f1f538a17111da0faa1
    Closes-Bug: #1552614

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.0.0.0rc1

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.