force_metadata = True : qdhcp namespace has no interface with ip 169.254.169.254

Bug #1549793 reported by Alex Stafeyev
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Li Xipeng

Bug Description

[root@overcloud-controller-0 ~]# cat /etc/neutron/dhcp_agent.ini | grep metadata | grep -v "#"
force_metadata = True
enable_isolated_metadata = False
enable_metadata_network = False

[stack@undercloud ~]$ neutron net-list
+--------------------------------------+----------------------------------------------------+-------------------------------------------------------+
| id | name | subnets |

| d7ebddcd-9989-4068-a8d9-66381e83d1f5 | int_net | 739b813d-4863-44e3-acd5-0bf6c3aaec76 192.168.3.0/24 |
+--------------------------------------+----------------------------------------------------+-------------------------------------------------------+

[root@overcloud-controller-0 ~]# ip netns exec qdhcp-d7ebddcd-9989-4068-a8d9-66381e83d1f5 ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
36: tap7002581e-a4: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN
    link/ether fa:16:3e:3b:e9:ae brd ff:ff:ff:ff:ff:ff
    inet 192.168.3.3/24 brd 192.168.3.255 scope global tap7002581e-a4
       valid_lft forever preferred_lft forever
    inet6 fe80::f816:3eff:fe3b:e9ae/64 scope link
       valid_lft forever preferred_lft forever

We should have interface on qdhcp namespace with 169.254.169.254 ip for metadata when "force_metadata = True" in /etc/neutron/dhcp-agent.ini.

VMs are not receiving metadata in this scenario

[root@overcloud-controller-0 ~]# rpm -qa | grep neutron
openstack-neutron-bigswitch-lldp-2015.1.38-1.el7ost.noarch
openstack-neutron-ml2-2015.1.2-9.el7ost.noarch
python-neutronclient-2.4.0-2.el7ost.noarch
python-neutron-2015.1.2-9.el7ost.noarch
openstack-neutron-2015.1.2-9.el7ost.noarch
openstack-neutron-lbaas-2015.1.2-1.el7ost.noarch
python-neutron-lbaas-2015.1.2-1.el7ost.noarch
openstack-neutron-common-2015.1.2-9.el7ost.noarch
openstack-neutron-openvswitch-2015.1.2-9.el7ost.noarch
openstack-neutron-metering-agent-2015.1.2-9.el7ost.noarch

[root@overcloud-controller-0 ~]# rpm -qa | grep meta
yum-metadata-parser-1.1.4-10.el7.x86_64

Alex Stafeyev (astafeye)
description: updated
Revision history for this message
Eugene Nikanorov (enikanorov) wrote :

since 169.254 is alias, it will not be shown in ifconfig output. Try running ip a in the namespace instead

Changed in neutron:
status: New → Incomplete
Revision history for this message
Eugene Nikanorov (enikanorov) wrote :

oops, sorry, disregard my comment, i've been running ip a.

It's possible that the combination of options is not working as expected. Probably dhcp agent should not start if settings contradict each other

Changed in neutron:
status: Incomplete → New
Li Xipeng (lixipeng)
Changed in neutron:
status: New → Confirmed
assignee: nobody → Li Xipeng (lixipeng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/286345

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/286951

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Li Xipeng (<email address hidden>) on branch: master
Review: https://review.openstack.org/286951
Reason: Already exist

Revision history for this message
Dariusz Smigiel (smigiel-dariusz) wrote :

@Li Xipeng could you provide additional information about this bugfix? You abandoned change, because already exists. Does it mean, this bug is invalid?

Changed in neutron:
status: In Progress → Incomplete
Revision history for this message
John Schwarz (jschwarz) wrote :

@Dariusz, the correct patch is https://review.openstack.org/#/c/286345/ - it seems that the one abandoned was a duplicate of this. The one I linked to is being actively worked on so this is still on progress.

Changed in neutron:
status: Incomplete → In Progress
Changed in neutron:
assignee: Li Xipeng (lixipeng) → Brian Haley (brian-haley)
Changed in neutron:
assignee: Brian Haley (brian-haley) → Li Xipeng (lixipeng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/286345
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=45bec12cfc27578597cd197334979d0aee73a2cf
Submitter: Jenkins
Branch: master

commit 45bec12cfc27578597cd197334979d0aee73a2cf
Author: Li Xipeng <email address hidden>
Date: Tue Feb 23 13:54:34 2016 -0800

    Add 169.254.169.254 when enable force_metadata

    When enable force_metadata in dhcp.ini, and create a network
    and a subnet, none 169.254.169.254/24 ip info set in related
    namespace(qdhcp-XXX) with `ip a` command. In this case, vms could
    not get metadata any more.

    Change-Id: Ib5b95f3afc6e66f66cdb7e1e98e5450a6e80a1b2
    Closes-Bug: #1549793

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This is being reverted in: https://review.openstack.org/#/c/304917/

It must be resubmitted so that it does not cause intermittent bug 1569507

Changed in neutron:
status: Fix Released → Confirmed
milestone: none → newton-1
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/305051

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/mitaka)

Change abandoned by John Schwarz (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/305051
Reason: Seems like the original patch was reverted so this should not be pushed.

Revision history for this message
John Schwarz (jschwarz) wrote :

Li, please confirm that you are still interested in fixing this issue. If not, please remove yourself as the assignee so that others may fix it instead.

Revision history for this message
Li Xipeng (lixipeng) wrote :

Hi, John Schwarz, fix is on the way.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/305615

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

Changed in neutron:
milestone: newton-1 → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/305615
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dfacba0f2d7586df51962c2b927e5272358ea3c1
Submitter: Jenkins
Branch: master

commit dfacba0f2d7586df51962c2b927e5272358ea3c1
Author: Li Xipeng <email address hidden>
Date: Tue Feb 23 13:54:34 2016 -0800

    Add 169.254.169.254 when enable force_metadata

    When enable force_metadata in dhcp.ini, and create a network
    and a subnet, none 169.254.169.254/24 ip info set in related
    namespace(qdhcp-XXX) with `ip a` command. In this case, vms could
    not get metadata any more.

    Change-Id: Ibd73824658c9759d32fa53ffcf41f2b719c1028b
    Closes-Bug: #1549793

Changed in neutron:
status: In Progress → Fix Released
tags: added: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/336872

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/336873

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b2

This issue was fixed in the openstack/neutron 9.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/liberty)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/336873
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

tags: added: mitaka-backport-potential
removed: neutron-proactive-backport-potential
tags: removed: metadata
tags: added: l3-ipam-dhcp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/336873
Reason: Liberty is in CVE only mode.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/mitaka)

Reviewed: https://review.openstack.org/336872
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1d610fce6a3289aba4551378ef66c89b81059f61
Submitter: Jenkins
Branch: stable/mitaka

commit 1d610fce6a3289aba4551378ef66c89b81059f61
Author: Li Xipeng <email address hidden>
Date: Tue Feb 23 13:54:34 2016 -0800

    Add 169.254.169.254 when enable force_metadata

    When enable force_metadata in dhcp.ini, and create a network
    and a subnet, none 169.254.169.254/24 ip info set in related
    namespace(qdhcp-XXX) with `ip a` command. In this case, vms could
    not get metadata any more.

    Change-Id: Ibd73824658c9759d32fa53ffcf41f2b719c1028b
    Closes-Bug: #1549793
    (cherry picked from commit dfacba0f2d7586df51962c2b927e5272358ea3c1)

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 8.4.0

This issue was fixed in the openstack/neutron 8.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.