TestMl2PortsV2.test_update_port_host_id_changed may fail depending on ML2 driver

[Isaku Yamahata]

TestMl2PortsV2.test_update_port_host_id_changed may fail depending on ML2 driver.

Concretely with ODL ML2 driver, the test fails because it changes port status to ACTIVE on port binding.
The assumption of the test is not always true.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/279843

[Federico Ressi (federico-ressi-9)]

A log with such error testing master branch:

http://osjenkins.ir.intel.com:8080/view/fressi/job/3rdparty-networking-odl-tox/ws/build/109/console.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/282446

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/282446
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=d8c9c53a51ff344a6c6850a4c92101cad2f4ccc3
Submitter: Jenkins
Branch: master

commit d8c9c53a51ff344a6c6850a4c92101cad2f4ccc3
Author: Isaku Yamahata <email address hidden>
Date: Fri Feb 19 09:46:10 2016 -0800

    bug work around of bug #1545218

    The bug of 1545218 is a blocker of networking-odl. The effort to fix is
    on going, but it would take time.
    This patch make the test skip as a work around to unblock the bug.
    Once the right fix goes in, this patch should be reverted.

    Change-Id: I6b2d6453e817d43c41eab779754672cd919a8a0a
    Partial-bug: #1545218

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/279843
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ad7b72963d462f9a512eca3b5a054d8ea33f2324
Submitter: Jenkins
Branch: master

commit ad7b72963d462f9a512eca3b5a054d8ea33f2324
Author: Isaku Yamahata <email address hidden>
Date: Fri Feb 12 18:53:38 2016 -0800

    unbreak unit test caused by c5fa665de3173f3ad82cc3e7624b5968bc52c08d

    The change set of c5fa665de3173f3ad82cc3e7624b5968bc52c08d
    introduced a new test TestMl2PortsV2.test_update_port_host_id_changed
    which isn't always correct depending on driver.
    ML2 driver may change port status to ACTIVE on port binding.
    With such driver, the test fails. Grep showed 5 decomposed driver
    don't have the assumption.
    So this patch makes the test to run only _process_bind_port() without
    calling full update_port() so that precommit/postcommit don't get
    involved.

    Change-Id: Ib034e2121914e5f253eb673261f26b4c8487f431
    Closes-Bug: #1545218

[Federico Ressi (federico-ressi-9)]

This should also close its duplicate bug:

https://bugs.launchpad.net/networking-odl/+bug/1545827

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b3 development milestone.

[Isaku Yamahata (yamahata)]

FYI I closed 1545827.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/308643

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/308649

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308643
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fa2c3784a65f293ff44c1d3dac3f91065f0dfc97
Submitter: Jenkins
Branch: stable/liberty

commit fa2c3784a65f293ff44c1d3dac3f91065f0dfc97
Author: Isaku Yamahata <email address hidden>
Date: Fri Feb 12 18:53:38 2016 -0800

    unbreak unit test caused by c5fa665de3173f3ad82cc3e7624b5968bc52c08d

    The change set of c5fa665de3173f3ad82cc3e7624b5968bc52c08d
    introduced a new test TestMl2PortsV2.test_update_port_host_id_changed
    which isn't always correct depending on driver.
    ML2 driver may change port status to ACTIVE on port binding.
    With such driver, the test fails. Grep showed 5 decomposed driver
    don't have the assumption.
    So this patch makes the test to run only _process_bind_port() without
    calling full update_port() so that precommit/postcommit don't get
    involved.

    Change-Id: Ib034e2121914e5f253eb673261f26b4c8487f431
    Closes-Bug: #1545218
    (cherry picked from commit ad7b72963d462f9a512eca3b5a054d8ea33f2324)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Isaku Yamahata (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/308649
Reason: As it's now unnecessary as Ihar stated.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dave Walker (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/306300
Reason:
stable/kilo closed for 2015.1.4

This release is now pending its final release and no freeze exception has
been seen for this changeset. Therefore, I am now abandoning this change.

If this is not correct, please urgently raise a thread on openstack-dev.

More details at: https://wiki.openstack.org/wiki/StableBranch

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 7.1.0 release.