neutron-meter-agent - makes traffic between internal networks NATed

Bug #1544508 reported by Dmitry Sutyagin
38
This bug affects 6 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Sergey Belous

Bug Description

If neutron-meter-agent is installed and enabled, and a meter-label is created, all traffic between internal networks becomes NATed, which is unexpected and potentially causes firewall/routing issues. This happens because meter-agent does not define stateless flag during iptables initialization which later during _modify_rules in agent/linux/iptables_manager.py results in moving the following rules:

before:
-A POSTROUTING -j neutron-l3-agent-POSTROUTING
-A POSTROUTING -j neutron-postrouting-bottom

after:
-A POSTROUTING -j neutron-postrouting-bottom
-A POSTROUTING -j neutron-l3-agent-POSTROUTING

The attached patch fixes the issue by setting "state_less=True" for metering agent's iptables_manager.

Revision history for this message
Dmitry Sutyagin (dsutyagin) wrote :
Revision history for this message
Dmitry Sutyagin (dsutyagin) wrote :
Revision history for this message
Martin Hickey (martin-hickey) wrote :

Hi Dmitry,

Do you want to go ahead and assign the bug and create a patch?

Regards,
Martin

Revision history for this message
Dmitry Sutyagin (dsutyagin) wrote :

Hi Martin,

I will try to do this tomorrow, but if I fail I will let know here and then you can take the fame :) (never submitted a patch for upstream yet)

Changed in neutron:
assignee: nobody → Dmitry Sutyagin (dsutyagin)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/279433

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
Dmitry Sutyagin (dsutyagin) wrote :

Did I succeed? :) One python test failed by timeout, should I re-run it somehow?

Revision history for this message
Dmitry Sutyagin (dsutyagin) wrote :

Looks like one of the tests failed by timeout again (this time a different one) - I do not know how to force a re-check, can anyone help?

Changed in neutron:
importance: Undecided → Medium
Changed in neutron:
assignee: Dmitry Sutyagin (dsutyagin) → Brian Haley (brian-haley)
Changed in neutron:
importance: Medium → High
milestone: none → newton-1
Changed in neutron:
assignee: Brian Haley (brian-haley) → Sergey Belous (sbelous)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/279433
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5d2d1120fcdcd5977d3c760ac1520a841048d456
Submitter: Jenkins
Branch: master

commit 5d2d1120fcdcd5977d3c760ac1520a841048d456
Author: Dmitry Sutyagin <email address hidden>
Date: Fri Feb 12 12:18:14 2016 +0300

    Switches metering agent to stateless iptables

    If state_less parameter is not specified then
    neutron-postrouting-bottom rule goes up in POSTROUTING
    chain, which causes premature NATing of traffic,
    for ex. traffic between internal networks becomes NATed.

    Closes-Bug: 1544508
    Co-Authored-By: Sergey Belous <email address hidden>
    Change-Id: I2e0011237d50a59d417cfee01dcd5f9d0da2e7f5

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/300288

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/300289

Akihiro Motoki (amotoki)
tags: added: liberty-backport-potential mitaka-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/mitaka)

Reviewed: https://review.openstack.org/300288
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=844cae4960cb2e3aedad750ceb91aa675f8e1142
Submitter: Jenkins
Branch: stable/mitaka

commit 844cae4960cb2e3aedad750ceb91aa675f8e1142
Author: Dmitry Sutyagin <email address hidden>
Date: Fri Feb 12 12:18:14 2016 +0300

    Switches metering agent to stateless iptables

    If state_less parameter is not specified then
    neutron-postrouting-bottom rule goes up in POSTROUTING
    chain, which causes premature NATing of traffic,
    for ex. traffic between internal networks becomes NATed.

    Closes-Bug: 1544508
    Co-Authored-By: Sergey Belous <email address hidden>
    Change-Id: I2e0011237d50a59d417cfee01dcd5f9d0da2e7f5
    (cherry picked from commit 5d2d1120fcdcd5977d3c760ac1520a841048d456)

tags: added: in-stable-mitaka
tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/liberty)

Reviewed: https://review.openstack.org/300289
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=695335bb360f07ed5ba813474f024cb0de05b7f6
Submitter: Jenkins
Branch: stable/liberty

commit 695335bb360f07ed5ba813474f024cb0de05b7f6
Author: Dmitry Sutyagin <email address hidden>
Date: Fri Feb 12 12:18:14 2016 +0300

    Switches metering agent to stateless iptables

    If state_less parameter is not specified then
    neutron-postrouting-bottom rule goes up in POSTROUTING
    chain, which causes premature NATing of traffic,
    for ex. traffic between internal networks becomes NATed.

    Closes-Bug: 1544508
    Co-Authored-By: Sergey Belous <email address hidden>
    Change-Id: I2e0011237d50a59d417cfee01dcd5f9d0da2e7f5
    (cherry picked from commit 5d2d1120fcdcd5977d3c760ac1520a841048d456)

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 8.1.0

This issue was fixed in the openstack/neutron 8.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/314250

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)
Download full text (36.9 KiB)

Reviewed: https://review.openstack.org/314250
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3bf73801df169de40d365e6240e045266392ca63
Submitter: Jenkins
Branch: master

commit a323769143001d67fd1b3b4ba294e59accd09e0e
Author: Ryan Moats <email address hidden>
Date: Tue Oct 20 15:51:37 2015 +0000

    Revert "Improve performance of ensure_namespace"

    This reverts commit 81823e86328e62850a89aef9f0b609bfc0a6dacd.

    Unneeded optimization: this commit only improves execution
    time on the order of milliseconds, which is less than 1% of
    the total router update execution time at the network node.

    This also

    Closes-bug: #1574881

    Change-Id: Icbcdf4725ba7d2e743bb6761c9799ae436bd953b

commit 7fcf0253246832300f13b0aa4cea397215700572
Author: OpenStack Proposal Bot <email address hidden>
Date: Thu Apr 21 07:05:16 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I9e930750dde85a9beb0b6f85eeea8a0962d3e020

commit 643b4431606421b09d05eb0ccde130adbf88df64
Author: OpenStack Proposal Bot <email address hidden>
Date: Tue Apr 19 06:52:48 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I52d7460b3265b5460b9089e1cc58624640dc7230

commit 1ffea42ccdc14b7a6162c1895bd8f2aae48d5dae
Author: OpenStack Proposal Bot <email address hidden>
Date: Mon Apr 18 15:03:30 2016 +0000

    Updated from global requirements

    Change-Id: Icb27945b3f222af1d9ab2b62bf2169d82b6ae26c

commit b970ed5bdac60c0fa227f2fddaa9b842ba4f51a7
Author: Kevin Benton <email address hidden>
Date: Fri Apr 8 17:52:14 2016 -0700

    Clear DVR MAC on last agent deletion from host

    Once all agents are deleted from a host, the DVR MAC generated
    for that host should be deleted as well to prevent a buildup of
    pointless flows generated in the OVS agent for hosts that don't
    exist.

    Closes-Bug: #1568206
    Change-Id: I51e736aa0431980a595ecf810f148ca62d990d20
    (cherry picked from commit 92527c2de2afaf4862fddc101143e4d02858924d)

commit eee9e58ed258a48c69effef121f55fdaa5b68bd6
Author: Mike Bayer <email address hidden>
Date: Tue Feb 9 13:10:57 2016 -0500

    Add an option for WSGI pool size

    Neutron currently hardcodes the number of
    greenlets used to process requests in a process to 1000.
    As detailed in
    http://lists.openstack.org/pipermail/openstack-dev/2015-December/082717.html

    this can cause requests to wait within one process
    for available database connection while other processes
    remain available.

    By adding a wsgi_default_pool_size option functionally
    identical to that of Nova, we can lower the number of
    greenlets per process to be more in line with a typical
    max database connection pool size.

    DocImpact: a previously unused configuration value
               wsgi_default_pool_size is now used to a...

tags: added: neutron-proactive-backport-potential
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 7.1.0

This issue was fixed in the openstack/neutron 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/330877

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/kilo)

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/330877
Reason: Kilo is EOL.

Revision history for this message
Davide (dpanarese) wrote :

Hi guys,
We run Openstack Juno and this problem causing huge problems to our customer.
Is it a good choice to backport fix code to our release? Could it cause some other problems?

Thanks,
Davide

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Davide, Juno is not supported. Even Kilo is not supported.

tags: removed: liberty-backport-potential neutron-proactive-backport-potential
tags: removed: mitaka-rc-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.