duplicated security groups in test_port_security_disable_security_group

[Armando Migliaccio]

An instance of the failure:

http://logs.openstack.org/10/275510/2/gate/gate-tempest-dsvm-neutron-linuxbridge/34fdca2/logs/testr_results.html.gz

Traceback (most recent call last):
  File "tempest/scenario/test_security_groups_basic_ops.py", line 166, in setUp
    self._deploy_tenant(self.primary_tenant)
  File "tempest/scenario/test_security_groups_basic_ops.py", line 306, in _deploy_tenant
    self._set_access_point(tenant)
  File "tempest/scenario/test_security_groups_basic_ops.py", line 272, in _set_access_point
    security_groups=secgroups)
  File "tempest/scenario/test_security_groups_basic_ops.py", line 250, in _create_server
    sorted([s['name'] for s in server['security_groups']]))
  File "/opt/stack/new/tempest/.tox/full/local/lib/python2.7/site-packages/testtools/testcase.py", line 362, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/opt/stack/new/tempest/.tox/full/local/lib/python2.7/site-packages/testtools/testcase.py", line 447, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = [u'tempest-secgroup_access--952188639', u'tempest-secgroup_general--210717852']
actual = [u'tempest-secgroup_access--952188639',
 u'tempest-secgroup_access--952188639',
 u'tempest-secgroup_general--210717852',
 u'tempest-secgroup_general--210717852']

You can notice the duplicated security groups.

More to follow.

[Armando Migliaccio (armando-migliaccio)]

Another failure:

http://logs.openstack.org/02/273002/6/gate/gate-tempest-dsvm-neutron-full/ae44f7c/logs/testr_results.html.gz

[Armando Migliaccio (armando-migliaccio)]

Logstash query:

message:"reference = [u'tempest-secgroup_access--"

[Armando Migliaccio (armando-migliaccio)]

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22reference%20%3D%20%5Bu'tempest-secgroup_access--%5C%22

Failed twice in the gate during the last 7 days.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/278609

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/278609
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eb8141051abe64de7ad9398fb2adaf9a0a79d62d
Submitter: Jenkins
Branch: master

commit eb8141051abe64de7ad9398fb2adaf9a0a79d62d
Author: Kevin Benton <email address hidden>
Date: Wed Feb 10 11:52:37 2016 -0800

    ML2: delete_port on deadlock during binding

    The previous logic was only catching mechanism driver exceptions so
    it would leave behind a partially built port if a deadlock was
    encountered during port binding.

    The bug this closes was caused by a DBDeadlock being encountered when
    a lock was attempted on the port binding record
    (get_locked_port_and_binding). This would not be caught so the API
    would retry the whole operation with the original created port
    left behind. This resulted in two ports assigned to the same instance.

    Closes-Bug: #1543880
    Change-Id: I694a9d58002d72636225f99a5fb2b1ccc1cfb6e5

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/280092

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/280092
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e93c5dce0b71ebebfeca31913928f07b77bbd0ae
Submitter: Jenkins
Branch: stable/liberty

commit e93c5dce0b71ebebfeca31913928f07b77bbd0ae
Author: Kevin Benton <email address hidden>
Date: Wed Feb 10 11:52:37 2016 -0800

    ML2: delete_port on deadlock during binding

    The previous logic was only catching mechanism driver exceptions so
    it would leave behind a partially built port if a deadlock was
    encountered during port binding.

    The bug this closes was caused by a DBDeadlock being encountered when
    a lock was attempted on the port binding record
    (get_locked_port_and_binding). This would not be caught so the API
    would retry the whole operation with the original created port
    left behind. This resulted in two ports assigned to the same instance.

    Closes-Bug: #1543880
    Change-Id: I694a9d58002d72636225f99a5fb2b1ccc1cfb6e5
    (cherry picked from commit eb8141051abe64de7ad9398fb2adaf9a0a79d62d)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b3 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 7.0.4 release.