neutron.tests.unit.agent.linux.test_async_process.TestFailingAsyncProcess.test_failing_async_process_handle_error_once failed in Liberty periodic job

[Ihar Hrachyshka]

http://logs.openstack.org/periodic-stable/periodic-neutron-python27-constraints-liberty/25e168f/testr_results.html.gz

  File "neutron/tests/unit/agent/linux/test_async_process.py", line 294, in test_failing_async_process_handle_error_once
    self.assertEqual(1, handle_error_mock.call_count)
  File "/home/jenkins/workspace/periodic-neutron-python27-constraints-liberty/.tox/py27-constraints/local/lib/python2.7/site-packages/testtools/testcase.py", line 350, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/home/jenkins/workspace/periodic-neutron-python27-constraints-liberty/.tox/py27-constraints/local/lib/python2.7/site-packages/testtools/testcase.py", line 435, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 1 != 0

Also note that in the same run, neutron.tests.unit.agent.linux.test_utils.AgentUtilsExecuteTest.test_encode_process_input failed too.

Traceback (most recent call last):
  File "neutron/tests/unit/agent/linux/test_utils.py", line 141, in test_encode_process_input
    self.mock_popen.assert_called_once_with(str_idata)
  File "/home/jenkins/workspace/periodic-neutron-python27-constraints-liberty/.tox/py27-constraints/local/lib/python2.7/site-packages/mock/mock.py", line 947, in assert_called_once_with
    raise AssertionError(msg)
AssertionError: Expected 'communicate' to be called once. Called 2 times.

The failing test was introduced in Liberty as part of https://review.openstack.org/#/c/272682/ backport.

[Nir Magnezi (nmagnezi)]

Turns out we need to back port the fix for Bug 1519160 to Liberty as well.
Find the backport here: https://review.openstack.org/#/c/277347/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/277347
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=306636e64dc884484aad772dd6994299d30c2a06
Submitter: Jenkins
Branch: stable/liberty

commit 306636e64dc884484aad772dd6994299d30c2a06
Author: Hong Hui Xiao <email address hidden>
Date: Tue Nov 24 09:01:48 2015 -0500

    Wait for the watch process in test case

    Because the _watch_process and the failing_process are asynchronous,
    there might be a chance that failing_process exit and _watch_process
    is not executed.

    If the _watch_process is blocked, the method that will be asserted
    will not be called. This will fail the UT, but it is intermittent.

    Change-Id: Ic951c1b91c5a10462f548544a5e8d482c52ad665
    Closes-Bug: #1519160
    Related-Bug: #1543040
    Related Bug: #1506021
    (cherry picked from commit dcd0498c17ae860c55a92f9f31b3e3fa0460b78e)

[Ihar Hrachyshka (ihar-hrachyshka)]

Backport landed in liberty, closed the bug.