Nobody listens to network delete notifications (OVS specific)

Bug #1540555 reported by Dmitry Mescheryakov
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Won't Fix
Medium
Nupur sharma

Bug Description

Here it can be seen that agents are notified of network delete event:
https://github.com/openstack/neutron/blob/8.0.0.0b2/neutron/plugins/ml2/rpc.py#L304

But on the agent side only network update events are being listened:
https://github.com/openstack/neutron/blob/8.0.0.0b2/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L374

That was uncovered during testing of Pika driver, because it does not allow to send messages to queues which do not exist, unlike current Rabbit (Kombu) driver. That behaviour will probably be changed in Pika driver, but still it is worthy to get rid of unnecessary notifications on Neutron side.

Changed in neutron:
assignee: nobody → Eugene Nikanorov (enikanorov)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Nate Johnston (nate-johnston) wrote :

You should probably rephrase the title of this bug to indicate that it is specific to OVS; other ML2 drivers may listen for network delete events.

Changed in neutron:
assignee: Eugene Nikanorov (enikanorov) → nobody
importance: Medium → Low
Revision history for this message
Nate Johnston (nate-johnston) wrote :

Apologies, Eugene, our changes crossed in the ether. Restoring your changes.

Changed in neutron:
assignee: nobody → Eugene Nikanorov (enikanorov)
importance: Low → Medium
Revision history for this message
Eugene Nikanorov (enikanorov) wrote :

It's correct observation, Nate.
Linux bridge agent uses this notification to delete network's bridge unlike OVS agent which only needs port delete notifications.
I think it's not a big deal if notifications are just lost if nobody consumes them.

Closing as invalid.

Changed in neutron:
status: Confirmed → Invalid
assignee: Eugene Nikanorov (enikanorov) → nobody
Ken Giusti (kgiusti)
Changed in neutron:
assignee: nobody → Ken Giusti (kgiusti)
assignee: Ken Giusti (kgiusti) → nobody
Revision history for this message
Oleksii Zamiatin (ozamiatin) wrote :

My concern is that correct behavior would be not to write to non existent topic. Looks like some code currently common to both backend drivers should be moved lower to a specific backend and removed from the others.

summary: - Nobody listens to network delete notifications
+ Nobody listens to network delete notifications (OVS specific)
Changed in neutron:
status: Invalid → New
Revision history for this message
Oleksii Zamiatin (ozamiatin) wrote :

BTW we've encountered the same with zmq messaging https://bugs.launchpad.net/neutron/+bug/1634884

Chenghui Yu (chenghuiyu)
Changed in neutron:
assignee: nobody → Chenghui Yu (chenghuiyu)
assignee: Chenghui Yu (chenghuiyu) → nobody
srikanth (k1039485)
Changed in neutron:
assignee: nobody → srikanth (k1039485)
Revision history for this message
srikanth (k1039485) wrote :

Hi Dimitry,

Updating the neutron backend rpc mechanism to handle specific notification by specific agent will not be inline with current neutron design.
Though network delete notification is not currently handled by ovs, this notification may be required by other agents in various deployments.

Revision history for this message
Nupur sharma (nupur.sharma) wrote :

Anybody working on this bug?? If not, I would like to assign it to myself.

Revision history for this message
srikanth (k1039485) wrote :

yes you can assign to yourself Nupur sharma

Changed in neutron:
assignee: srikanth (k1039485) → Nupur sharma (nupur.sharma)
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Bug closed due to lack of activity, please feel free to reopen if needed.

Changed in neutron:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.