Pecan: filter values are not converted

Bug #1537924 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Salvatore Orlando

Bug Description

The code [1], in order to work as expected, needs a call like [2].
Otherwise every filter value is sent down to the plugin as a string and the plugin will not like that.

[1] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/controllers/root.py#n159
[2] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/api/api_common.py#n32

Tags: pecan
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/272311

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/272311
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f392a04051ac45dc023a594d605420ef30a19a2e
Submitter: Jenkins
Branch: master

commit f392a04051ac45dc023a594d605420ef30a19a2e
Author: Salvatore Orlando <email address hidden>
Date: Mon Jan 25 14:23:13 2016 -0800

    Pecan: filter items need type conversion

    In order for filtering to work properly on GET requests, filter
    values should be converted to the appropriate type specified in
    neutron.api.v2.attributes.RESOURCE_ATTRIBUTE_MAP.

    Without this change queries on boolean attributes, for instance,
    won't work as the value to filter on will be passed to the plugin
    as a string.

    Closes Bug: #1537924

    Change-Id: I0a697a01f272f94378928ecc099232e3b2d11f1f

Changed in neutron:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.